Re: (sashiko review) [RFC PATCH v5.2 07/11] Docs/ABI/damon: document fail_charge_{num,denom}

SeongJae Park
2026-04-12T18:10:32Z

TL; DR: Sashiko found no issue but hallucinated.

Forwarding full sashiko review in a reply format with my inline comments below,
for sharing details of my view and doing followup discussions via mails if
needed.

> # review url: https://sashiko.dev/#/patchset/20260412161957.82835-8-sj@kernel.org
> # start of sashiko.dev inline review
> commit 4091d558c881126aba4445ec7fa5033266c62c55
> Author: SeongJae Park <sj@kernel.org>
>
> Docs/ABI/damon: document fail_charge_{num,denom}
>
> Update DAMON ABI document for the DAMOS action failed regions quota
> charge ratio control sysfs files.
>
> > diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-damon b/Documentation/ABI/testing/sysfs-kernel-mm-damon
> > index 2424237ebb105..213eb87392d88 100644
> > --- a/Documentation/ABI/testing/sysfs-kernel-mm-damon
> > +++ b/Documentation/ABI/testing/sysfs-kernel-mm-damon
> > @@ -322,6 +322,18 @@ Contact: SeongJae Park <sj@kernel.org>
> > Description: Writing to and reading from this file sets and gets the
> > goal-based effective quota auto-tuning algorithm to use.
> >
> > +What: /sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/schemes//quotas/fail_charge_num
> > +Date: Mar 2026
>
> This isn't a bug, but is the year 2026 a typo?

Apparently a hallucination of Sashiko.

>
> > +Contact: SeongJae Park <sj@kernel.org>
> > +Description: Writing to and reading from this file sets and gets the
> > + action-failed memory quota charging ratio numerator.
> > +
> > +What: /sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/schemes//quotas/fail_charge_denom
> > +Date: Mar 2026
>
> Is the year a typo here as well?

Ditto.

>
> > +Contact: SeongJae Park <sj@kernel.org>
> > +Description: Writing to and reading from this file sets and gets the
> > + action-failed memory quota charging ratio denominator.
>
>
> # end of sashiko.dev inline review
> # review url: https://sashiko.dev/#/patchset/20260412161957.82835-8-sj@kernel.org

Thanks,
SJ

# hkml [1] generated a draft of this mail. You can regenerate
# this using below command:
#
# hkml patch sashiko_dev --for_forwarding \
# 20260412161957.82835-8-sj@kernel.org
#
# [1] https://github.com/sjp38/hackermail