From: Andrew Morton <akpm@linux-foundation.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "David Hildenbrand (Arm)" <david@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Jason Gunthorpe <jgg@ziepe.ca>,
John Hubbard <jhubbard@nvidia.com>, Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH v2] mm/gup: honour FOLL_PIN in NOMMU __get_user_pages_locked()
Date: Fri, 24 Apr 2026 04:39:48 -0700 [thread overview]
Message-ID: <20260424043948.a1b0ef6218e3dc13e5f7a97d@linux-foundation.org> (raw)
In-Reply-To: <2026042431-charter-ranging-597c@gregkh>
On Fri, 24 Apr 2026 13:31:34 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > > @@ -2019,8 +2020,14 @@ static long __get_user_pages_locked(struct mm_struct *mm, unsigned long start,
> > >
> > > if (pages) {
> > > pages[i] = virt_to_page((void *)start);
> > > - if (pages[i])
> > > - get_page(pages[i]);
> > > + if (!pages[i])
> > > + break;
> >
> > Best to mention that change in the patch description. I really think this is the
> > right thing to do (returning NULL in the page array is just very dubious).
>
> Ick, I see Andrew already grabbed this so I'll just leave it for now,
> thanks for the help and review!
Andrew does copy-n-paste ;)
next prev parent reply other threads:[~2026-04-24 11:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 14:28 [PATCH v2] mm/gup: honour FOLL_PIN in NOMMU __get_user_pages_locked() Greg Kroah-Hartman
2026-04-23 15:55 ` David Hildenbrand (Arm)
2026-04-24 11:31 ` Greg Kroah-Hartman
2026-04-24 11:39 ` Andrew Morton [this message]
2026-04-24 12:16 ` David Hildenbrand (Arm)
2026-04-24 12:41 ` Andrew Morton
2026-04-24 12:49 ` David Hildenbrand (Arm)
2026-04-24 13:38 ` Andrew Morton
2026-04-24 14:04 ` Greg Kroah-Hartman
2026-04-24 14:19 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260424043948.a1b0ef6218e3dc13e5f7a97d@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox