From: Heiko Carstens <hca@linux.ibm.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Kevin Brodsky <kevin.brodsky@arm.com>,
David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/6] s390/mm: Complete ptep_get() conversion
Date: Fri, 24 Apr 2026 14:34:09 +0200 [thread overview]
Message-ID: <20260424123409.17231A9d-hca@linux.ibm.com> (raw)
In-Reply-To: <0ce9c2f7-e9cc-4018-92fe-a2a966889181-agordeev@linux.ibm.com>
On Fri, Apr 24, 2026 at 01:54:18PM +0200, Alexander Gordeev wrote:
> On Thu, Apr 23, 2026 at 12:51:18PM +0200, Heiko Carstens wrote:
> > Was this a manual conversion, or did you use some tooling?
>
> Manual :) But I will try to recheck with a tool.
>
> > I'm wondering since I can spot not converted locations, e.g. one in
> > __kernel_map_pages().
>
> Whether this fixup is fine?
>
> diff --git a/arch/s390/mm/pageattr.c b/arch/s390/mm/pageattr.c
> index 3a54860cb05f..e6f788696dd1 100644
> --- a/arch/s390/mm/pageattr.c
> +++ b/arch/s390/mm/pageattr.c
> @@ -455,7 +455,8 @@ void __kernel_map_pages(struct page *page, int numpages, int enable)
> nr = min(numpages - i, nr);
> if (enable) {
> for (j = 0; j < nr; j++) {
> - pte = clear_pte_bit(*ptep, __pgprot(_PAGE_INVALID));
> + pte = ptep_get(ptep);
> + pte = clear_pte_bit(pte, __pgprot(_PAGE_INVALID));
Sure.
next prev parent reply other threads:[~2026-04-24 12:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 15:01 [PATCH v2 0/6] s390/mm: Batch PTE updates in lazy MMU mode Alexander Gordeev
2026-04-15 15:01 ` [PATCH v2 1/6] mm: Make lazy MMU mode context-aware Alexander Gordeev
2026-04-20 8:45 ` Kevin Brodsky
2026-04-21 4:57 ` Alexander Gordeev
2026-04-21 8:40 ` Kevin Brodsky
2026-04-21 14:12 ` David Hildenbrand (Arm)
2026-04-21 14:15 ` David Hildenbrand (Arm)
2026-04-21 14:25 ` Alexander Gordeev
2026-04-23 10:49 ` Heiko Carstens
2026-04-15 15:01 ` [PATCH v2 2/6] mm/pgtable: Fix bogus comment to clear_not_present_full_ptes() Alexander Gordeev
2026-04-16 7:58 ` David Hildenbrand (Arm)
2026-04-16 8:53 ` Alexander Gordeev
2026-04-15 15:01 ` [PATCH v2 3/6] s390/mm: Complete ptep_get() conversion Alexander Gordeev
2026-04-23 10:51 ` Heiko Carstens
2026-04-24 11:54 ` Alexander Gordeev
2026-04-24 12:34 ` Heiko Carstens [this message]
2026-04-15 15:01 ` [PATCH v2 4/6] s390/mm: Make PTC and UV call order consistent Alexander Gordeev
2026-04-23 10:54 ` Heiko Carstens
2026-04-24 11:35 ` Alexander Gordeev
2026-04-15 15:01 ` [PATCH v2 5/6] s390/mm: Batch PTE updates in lazy MMU mode Alexander Gordeev
2026-04-16 5:40 ` Heiko Carstens
2026-04-16 5:51 ` Alexander Gordeev
2026-04-23 12:28 ` Heiko Carstens
2026-04-24 13:10 ` Alexander Gordeev
2026-04-15 15:01 ` [PATCH v2 6/6] s390/mm: Allow lazy MMU mode disabling Alexander Gordeev
2026-04-16 5:44 ` Heiko Carstens
2026-04-16 7:00 ` Alexander Gordeev
2026-04-16 8:22 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260424123409.17231A9d-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kevin.brodsky@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox