public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Haifeng Xu <haifeng.xu@shopee.com>
Cc: david@fromorbit.com, roman.gushchin@linux.dev,
	hannes@cmpxchg.org, mhocko@kernel.org, shakeel.butt@linux.dev,
	zhengqi.arch@bytedance.com, muchun.song@linux.dev,
	usama.arif@linux.dev, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 0/4] record non-slab shrinkers for non-root memcgs when kmem is disabled
Date: Sat, 25 Apr 2026 14:04:45 -0700	[thread overview]
Message-ID: <20260425140445.14ab61224955c88d359dd6f7@linux-foundation.org> (raw)
In-Reply-To: <20260311030235.240953-1-haifeng.xu@shopee.com>

On Wed, 11 Mar 2026 11:02:31 +0800 Haifeng Xu <haifeng.xu@shopee.com> wrote:

> When registering new shrinkers, all memcgs need to expand shrinker info
> if new allocated id exceeds shrinker_nr_max. But if kmem is disabled,
> only non-slab shrinkers is useful in memcg slab shrink. So in this case,
> it is enough to allocate non-slab shrinker info for non-root memcg. This
> can save a bit of memory and reduce the holding time of shrinker lock.

Are you able to estimate how much memory it will save?

> With this optimization, the finish time of pod creation in our internal
> test is reduced from 150 seconds to 69 seconds. We test it based on
> stable kernel 6.6.102.

Is that internal test some crazy thing or is it representative of a
real-world workload?

IOW, what I'd like to see in your [0/N] is some indication of how much
time and memory we can expect real-world Linux users to see in
real-world workloads.

So please have a think about that, add some words then resend the
patchset.

Thanks.


      parent reply	other threads:[~2026-04-25 21:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11  3:02 [PATCH V3 0/4] record non-slab shrinkers for non-root memcgs when kmem is disabled Haifeng Xu
2026-03-11  3:02 ` [PATCH V3 1/4] mm: shrinker: add one more parameter in shrinker_id() Haifeng Xu
2026-03-11  3:02 ` [PATCH V3 2/4] mm: shrinker: move shrinker_id() code block below memcg_kmem_online() Haifeng Xu
2026-03-11  3:02 ` [PATCH V3 3/4] mm: shrinker: optimize the allocation of shrinker_info when setting cgroup_memory_nokmem Haifeng Xu
2026-03-11 21:19   ` Andrew Morton
2026-03-12  4:16     ` Haifeng Xu
2026-03-11  3:02 ` [PATCH V3 4/4] mm: shrinker: remove unnecessary check in shrink_slab_memcg() Haifeng Xu
2026-04-25 21:04 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260425140445.14ab61224955c88d359dd6f7@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=david@fromorbit.com \
    --cc=haifeng.xu@shopee.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=muchun.song@linux.dev \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeel.butt@linux.dev \
    --cc=usama.arif@linux.dev \
    --cc=zhengqi.arch@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox