Re: [PATCH v7] mm/damon: add node_eligible_mem_bp goal metric

SeongJae Park
2026-04-25T15:37:37Z

On Fri, 24 Apr 2026 21:18:57 -0700 Ravi Jonnalagadda <ravis.opensrc@gmail.com> wrote:

> On Fri, Apr 24, 2026 at 5:39 PM SeongJae Park <sj@kernel.org> wrote:
> >
> > Hello Ravi,
> >
> >
> > This version looks good, except very trivial nits.
>
> Hi SJ,
>
> Thanks for the super quick review! Very helpful.

My pleasure!

[...]
> > So this looks good to me, except the trivial things I commented above. Could
> > you please revision for the last time?
>
> Will do. Summary of changes for v8:
> 1. Mention addr filters for source-node filtering in Two-Scheme
> Setup
> 2. Move implementation details to commentary area with full
> changelog
> 3. Wrap the 80-column violation in damon_commit_ctx()
> 4. Use PAGE_ALIGN_DOWN(addr + PAGE_SIZE) for alignment
> 5. Wrap damos_goal_tune_esz_bp_temporal() (81 chars)
> 6. Remove unintended damos_trace_esz() from first charge window

Sounds good, looking forward to the v8!

Thanks,
SJ …