Re: [PATCH v4 08/11] PCI: liveupdate: Require preserved devices are in immutable singleton IOMMU groups

David Matlack
2026-04-30T20:49:32Z

On 2026-04-27 01:56 PM, Jacob Pan wrote:
> On Thu, 23 Apr 2026 21:23:12 +0000
> David Matlack <dmatlack@google.com> wrote:

> > +bool pci_device_group_immutable_singleton(struct pci_dev *dev)
> > +{
> > + struct iommu_group *group;
> > + struct group_device *d;
> > + struct pci_bus *bus;
> > + int nr_devices = 0;
> > +
> > + group = iommu_group_get(&dev->dev);
> > + if (!group)
> > + return false;
> This may not work for noiommu mode where we could have a null group.
> Maybe I can add special case later?

Yeah depending which series goes in first. But based on the other thread
I am going to drop this patch from v5.