From: Andrew Morton <akpm@linux-foundation.org>
To: Frederick Mayle <fmayle@google.com>
Cc: Matthew Wilcox <willy@infradead.org>,
android-mm@google.com, kernel-team@android.com,
Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] mm/readahead: simplify page_cache_ra_unbounded loop counter reset
Date: Fri, 8 May 2026 12:24:22 -0700 [thread overview]
Message-ID: <20260508122422.00ec86bcaf2fd3685332830e@linux-foundation.org> (raw)
In-Reply-To: <CAHCxdc5Kug-o8ubLmZgeQdcFmhvAMmAtNUc95t1kx3Wjggbnvw@mail.gmail.com>
On Thu, 7 May 2026 19:01:27 -0700 Frederick Mayle <fmayle@google.com> wrote:
> On Fri, May 1, 2026 at 6:11 AM Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > On Thu, 30 Apr 2026 18:19:07 -0700 Frederick Mayle <fmayle@google.com> wrote:
> >
> > > Minor cleanup, no behavior change intended.
> > >
> > > `read_pages` ensures that `ractl->_nr_pages` is zero before it returns,
> >
> > So it seems, but depending upon this might be a bit fragile?
> >
> > It would be better to make this a more explicit/formal part of the
> > read_pages() contract. kerneldocifying read_pages() would be a
> > suitable way.
>
> I agree. I've sent the following patch to document the invariant
> https://lore.kernel.org/r/20260508015402.735441-1-fmayle@google.com/
Thanks. I suggest you turn both into a single patch and resend when
people have returned and recovered from the conference ;)
prev parent reply other threads:[~2026-05-08 19:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 1:19 [PATCH 1/1] mm/readahead: simplify page_cache_ra_unbounded loop counter reset Frederick Mayle
2026-05-01 13:11 ` Andrew Morton
2026-05-08 2:01 ` Frederick Mayle
2026-05-08 19:24 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508122422.00ec86bcaf2fd3685332830e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=android-mm@google.com \
--cc=fmayle@google.com \
--cc=jack@suse.cz \
--cc=kernel-team@android.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox