From: Andrew Morton <akpm@linux-foundation.org>
To: Joonwon Kang <joonwonkang@google.com>
Cc: dennis@kernel.org, tj@kernel.org, cl@gentwo.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
dodam@google.com
Subject: Re: [PATCH v4 1/4] percpu: Fix wrong chunk hints update
Date: Fri, 8 May 2026 15:01:38 -0700 [thread overview]
Message-ID: <20260508150138.3c90c36d08d140fdb7cf55dd@linux-foundation.org> (raw)
In-Reply-To: <20260506142100.1289509-1-joonwonkang@google.com>
On Wed, 6 May 2026 14:20:56 +0000 Joonwon Kang <joonwonkang@google.com> wrote:
> Chunk end offset was set to a block end offset, which could prevent
> chunk hints from being updated correctly. It was observed that the chunk
> free size gets minus or shorter than the actual free size due to this.
> This commit fixes it.
AI review:
https://sashiko.dev/#/patchset/20260506142100.1289509-1-joonwonkang@google.com
The first comment seems valid:
CC mm/percpu-stats.o
mm/percpu-stats.c: In function 'chunk_map_stats':
mm/percpu-stats.c:125:9: error: aggregate value used where an integer was expected
125 | P("contig_bytes", chunk_md->contig_hint * PCPU_MIN_ALLOC_SIZE);
| ^
next prev parent reply other threads:[~2026-05-08 22:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 14:20 [PATCH v4 1/4] percpu: Fix wrong chunk hints update Joonwon Kang
2026-05-06 14:20 ` [PATCH v4 2/4] percpu: Do not trust hint starts when they are not set Joonwon Kang
2026-05-06 14:20 ` [PATCH v4 3/4] percpu: Introduce struct pcpu_region Joonwon Kang
2026-05-06 14:20 ` [PATCH v4 4/4] percpu: Fix hint invariant breakage Joonwon Kang
2026-05-08 22:01 ` Andrew Morton [this message]
2026-05-10 6:50 ` [PATCH v4 1/4] percpu: Fix wrong chunk hints update Joonwon Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508150138.3c90c36d08d140fdb7cf55dd@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=dennis@kernel.org \
--cc=dodam@google.com \
--cc=joonwonkang@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox