From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 172C8CD37BE for ; Mon, 11 May 2026 15:39:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D4236B00DF; Mon, 11 May 2026 11:39:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5851C6B00E0; Mon, 11 May 2026 11:39:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44D106B00E1; Mon, 11 May 2026 11:39:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 351AA6B00DF for ; Mon, 11 May 2026 11:39:46 -0400 (EDT) Received: from smtpin14.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D31ED1C0093 for ; Mon, 11 May 2026 15:39:45 +0000 (UTC) X-FDA: 84755549130.14.C23EF14 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) by imf01.hostedemail.com (Postfix) with ESMTP id E7F0E40010 for ; Mon, 11 May 2026 15:39:43 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=debian.org header.s=smtpauto.stravinsky header.b=SoEFslgk; dmarc=pass (policy=none) header.from=debian.org; spf=pass (imf01.hostedemail.com: domain of leitao@debian.org designates 82.195.75.108 as permitted sender) smtp.mailfrom=leitao@debian.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1778513984; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9eczhBxewuo2JvFN1og+M00zMC+sIzResfPi7F2/71E=; b=bkS0umeRvqN/PaHhd0f3gtNWhH9Oic2JBWDsF1E1Lqzn2xK3PIEXBp07k+vS4euPHoBzB2 ts71fvrBFFq+3ovX6zgO7fV0EL2RLQ62bfNAIS+eIIkWUCiaK2CcY6OzL1v3gcaZLB8igS n8Lpt3KgARYdPZX/uWzX9lYAhXK+fkA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1778513984; a=rsa-sha256; cv=none; b=Nqk2CeaN/ysJ1hqhNbBON3K3p5gUDRBBLmhmFUAJ2YidwS3snbo8+6h5yzrfAwhy5j5OSy 4XuYov20AsUlLvYFVh2leMRHXsKvDfXLnvvk4246wutIaU4l6vWj39A9n9q2MSjaUNAC8C +k38BXCJXHoamIrSCBkL+9fSWY6Fdko= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=debian.org header.s=smtpauto.stravinsky header.b=SoEFslgk; dmarc=pass (policy=none) header.from=debian.org; spf=pass (imf01.hostedemail.com: domain of leitao@debian.org designates 82.195.75.108 as permitted sender) smtp.mailfrom=leitao@debian.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=9eczhBxewuo2JvFN1og+M00zMC+sIzResfPi7F2/71E=; b=SoEFslgknWcDSrruLzc6WlAxLC 3mMn9cFGHBHyFJi/up4p4QPSrz3kdxwOGdJElMDREJSORbSiZvg2hY5Dn9IezBsFyhvvDLguunyCr VBsxzu+Ulhl9ZsJAaNe3Nh6e+tFYQnigtazd4YO47qvyw34mUo+Ra2325C++qZv6it22oqvmOOZdY s6fwrg6MNbvjKU9p0hMWET1VvNtipiqpPGuphB5Kc6+DU7S5f9jrqt3IofvnC8x3LJ45Ei+RYOL29 zFO1DCWRfd9iA74ZzmPT1cWZeOGqRfxzIMPWzOuGYzI+PG51bnsffpGwQKA/R71IHqzar9N0nCCcP kBvHKLyA==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1wMSjI-001hVR-2i; Mon, 11 May 2026 15:39:37 +0000 From: Breno Leitao Date: Mon, 11 May 2026 08:38:37 -0700 Subject: [PATCH v6 3/4] mm/memory-failure: add panic option for unrecoverable pages MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260511-ecc_panic-v6-3-183012ba7d4b@debian.org> References: <20260511-ecc_panic-v6-0-183012ba7d4b@debian.org> In-Reply-To: <20260511-ecc_panic-v6-0-183012ba7d4b@debian.org> To: Miaohe Lin , Naoya Horiguchi , Andrew Morton , Jonathan Corbet , Shuah Khan , David Hildenbrand , Lorenzo Stoakes , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , "Liam R. Howlett" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Breno Leitao , linux-trace-kernel@vger.kernel.org, kernel-team@meta.com X-Mailer: b4 0.16-dev-d5d98 X-Developer-Signature: v=1; a=openpgp-sha256; l=3232; i=leitao@debian.org; h=from:subject:message-id; bh=3WH08KBPaFAFZH+gyAtBCRzaUv1S7Oemd/2clegvfv0=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBqAfgg6LbRP3E9quuqNfU29bb3SDfqIGPF51mon h5IfI1EdvCJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCagH4IAAKCRA1o5Of/Hh3 bWJMD/9DaFTTwirbNnP+mpFf7x8UBJ81HYXeu/QS51MfqGkVR5U0eG8Gt8zRRtiJ0/PAHebDQmG zgKlONyzGuBhm7oq3WF4pQNUZ5qVKFpkGwvuEA+oGbQKbcGDsxM6FkUAljo3DlLcpjGKthEBzmP CZlULeNx4WzgL84wQGxPV2GWJCuBIUkZj9UV6nmy5aHDzY+xXewm3thrlxq4ihM2mB9pIDfz+LP 6bZnLR4hkkK4un09+UfW7dpzbfJb4Jdpsh8W+qJBh3cMUf3Y0dmyyJ+RoB+2ang38KizQCQgqC1 2hiCemU76StagplXoRk00IJy9bv/pXiW4y8xKC2KMOFgv7cUysb3TWRDhGA0VRAN68ygySBUI6t JNjIdKEcGTcSdZOFlvbYgys/UmvGLIY/pEPqN+WsMOr2Uk1BiJGTSgxvgLGwMFCbhSoXLJaYpYj ZICAIAms0EohYnzuWMdlZlveLfSyTdVqhIzK1z9K8J6U5w4IYwiwOWUgAWvfrqPJxeE9AgH6MKi 7Bvq4oNRKhMIDoogOtNvi5fKX3PD1gaFsRX0qBM0iKt6wQX4c8IyE75wTnkgsVzjptLO7MuV331 ZQnnr2ONPSZ+u5Kpw7NA9rBp29QxCWT+TpSmmlS6dwKg5aCGTHIhw2mRISNo7thyCu+4/9jHqf/ a1k53Ji8sW2fbNA== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao X-Rspam-User: X-Rspamd-Queue-Id: E7F0E40010 X-Rspamd-Server: rspam04 X-Stat-Signature: uo78h4n6x3ceryyjpnooy4sm4zbppjou X-HE-Tag: 1778513983-140746 X-HE-Meta: U2FsdGVkX1/aEPdi/0rNGgaUxtTtBaDRDQ9L7LlJBWfgQUg6JBTP1c4dhsELwcQtrj0tq6HtLqbWtmYW99t/B/C7IwtJezqBXzBWHqC5Hv52u93v15XWLSifTqR8nP9vDH/V4JNljugl6NFzfBiebIaG+LgIJpYjLS77gPFNgcCfksbCGU0xjMrg07lJNA8rJI63ZdkmduoBZkCIuCtkyadyQp9fBBxpQq3PySD59F3kW1QJ7lj9kpnctYqFn7zI1cS7ml8401isButpXWa80h6rOpJ9ZbuOVzictxY7eYAEOAoxMoKBePn+8NDyh1DS6+MvP59meP0x2q8piJwlLJfuvefYL4hIuwlJrBRWMqWZa+DOY9bnFjSfK/kEdPwDOnFE3Zn66JpdDbB3Gq8SBmQutba65FsyRgP0U2ndyWuTLeZ9L7ImOxy0QhOnVgPIhqnHJgxZ/jFARi7iIZy5BeybNF7ySXFrb7tKlscGnTsrxKwbyns18/1FjkhcsW4sjX99rspX7/cjggDEP3DljrTfHxSbHawDFSmkof/vpc+pC28z1rdL5uQx7arXuXia9lL8OYeBDbGA9CZOi4cmpFLwro8ejKak0HhX0qB/6v3AX36oQohe21R6t7BXD37LC77y/sf9NVjE44BDIK2pLblg64iMQrOlTLlNIc2tePfXPEQYk+126GgCqTHO+g9PG4Vc5DieQCtT1GkrEBv/ZtRxQpGmSUHbJWXH049HCOiA+vM95wqoT49JiXGA1dqyPi0E1n602d0hgu0Rubs0MIzCWB5n8yupfDoaDdPs4kDt4RPjkKiPbAQfqaY5cRt76zDt8o8WlcGxRhi2dP0IWs4LrTyvrR5D8zR9TURSM1g7bPurnoVJk/omUaULoqmP271KbKPT4QLHFKDHk7kE9Q1MQL8SjuymyLalJu6v9RSeCZkm9eY/CB8nHJjFSxdJkB808sqJodxFJloc9E2 plkVKzvD dAInEYV/mFd0xgmFbY+jK0REpXzJTQIC/okwie4xvhJ3kzjyThwhaSn6BjyJPb83k/il4bR8AOjeINZocZx86bhf8gz2ozmhYTqO+tFG91ImGg8TbtK/swHDtuY8E+fQyL2ml0D78PO7XAweD22NHutiVIy/tte1FQtrif46z0CNMDgJXc+ebmXzCdCdpWojyH3mMPK2FEI0epZOqQFRTgWY/QBWakMh8w6Vwd9aEjR9qjjL5jbrD4SbpEUVyOKDFum1cSBj4oW2bJWaxgLy28iPppIna0NTz18Y73qy4rKDp65U5Ub2rJEzkAQRaNXOejbK/ALIOWgxVXxYQ3VtEpGQ1mQ== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add a sysctl panic_on_unrecoverable_memory_failure that triggers a kernel panic when memory_failure() encounters pages that cannot be recovered. This provides a clean crash with useful debug information rather than allowing silent data corruption or a delayed crash at an unrelated code path. Panic eligibility is intentionally narrow: only MF_MSG_KERNEL with result == MF_IGNORED panics. That covers reserved pages (PageReserved) and the kernel page types that the prior patch promotes from MF_MSG_GET_HWPOISON via MF_GET_PAGE_UNHANDLABLE — slab, vmalloc, page tables, kernel stacks, and similar non-LRU/non-buddy kernel-owned pages. All other action types are excluded: - MF_MSG_GET_HWPOISON and MF_MSG_KERNEL_HIGH_ORDER can be reached by transient refcount races with the page allocator (an in-flight buddy allocation has refcount 0 and is no longer on the buddy free list, briefly), and panicking on them would risk killing the box for what is actually a recoverable userspace page. - MF_MSG_UNKNOWN means identify_page_state() could not classify the page; that is precisely the wrong basis for a panic decision. Signed-off-by: Breno Leitao --- mm/memory-failure.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 4210173060aac..e4a9ceacaf36b 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -74,6 +74,8 @@ static int sysctl_memory_failure_recovery __read_mostly = 1; static int sysctl_enable_soft_offline __read_mostly = 1; +static int sysctl_panic_on_unrecoverable_mf __read_mostly; + atomic_long_t num_poisoned_pages __read_mostly = ATOMIC_LONG_INIT(0); static bool hw_memory_failure __read_mostly = false; @@ -155,6 +157,15 @@ static const struct ctl_table memory_failure_table[] = { .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, + }, + { + .procname = "panic_on_unrecoverable_memory_failure", + .data = &sysctl_panic_on_unrecoverable_mf, + .maxlen = sizeof(sysctl_panic_on_unrecoverable_mf), + .mode = 0644, + .proc_handler = proc_dointvec_minmax, + .extra1 = SYSCTL_ZERO, + .extra2 = SYSCTL_ONE, } }; @@ -1281,6 +1292,18 @@ static void update_per_node_mf_stats(unsigned long pfn, ++mf_stats->total; } +static bool panic_on_unrecoverable_mf(enum mf_action_page_type type, + enum mf_result result) +{ + if (!sysctl_panic_on_unrecoverable_mf || result != MF_IGNORED) + return false; + + if (type == MF_MSG_KERNEL) + return true; + + return false; +} + /* * "Dirty/Clean" indication is not 100% accurate due to the possibility of * setting PG_dirty outside page lock. See also comment above set_page_dirty(). @@ -1298,6 +1321,9 @@ static int action_result(unsigned long pfn, enum mf_action_page_type type, pr_err("%#lx: recovery action for %s: %s\n", pfn, action_page_types[type], action_name[result]); + if (panic_on_unrecoverable_mf(type, result)) + panic("Memory failure: %#lx: unrecoverable page", pfn); + return (result == MF_RECOVERED || result == MF_DELAYED) ? 0 : -EBUSY; } -- 2.53.0-Meta