Re: [PATCH v5 0/2] mm/damon: validate min_region_size to be power of 2

[SeongJae Park <sj@kernel.org>]

Hi Andrew,

On Fri,  1 May 2026 09:37:48 +0800 Liew Rui Yan <aethernet65535@gmail.com> wrote:

> Problem
> =======
> When a user sets an invalid 'addr_unit' (e.g., 3) via DAMON_LRU_SORT or
> DAMON_RECLAIM, 'min_region_sz' becomes a non-power-of-2 value. While
> damon_commit_ctx() correctly detects this and returns -EINVAL, it sets
> the 'maybe_corrupted' flag during this process.
> 
> This flag causes the running kdamond to terminate. While the termination
> is a safety measure, it is suboptimal in this case because the error is
> just a simple invalid input from the user, which shouldn't neccessitate
> stopping the kdamond.
> 
> Solution
> ========
> Add an early validation in damon_lru_sort_apply_parameters() and
> damon_reclaim_apply_parameters() to check 'min_region_sz' before any
> state change occurs. If it is non-power-of-2, return -EINVAL immediately,
> preventing 'maybe_corrupted' from being set.


I think this series is good to go in my opinion.  Could you please add this
series into mm.git?


Thanks,
SJ

[...]