From: SeongJae Park <sj@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [RFC PATCH v2 03/28] mm/damon/core: introduce damon_filter
Date: Tue, 12 May 2026 07:36:18 -0700 [thread overview]
Message-ID: <20260512143645.113201-4-sj@kernel.org> (raw)
In-Reply-To: <20260512143645.113201-1-sj@kernel.org>
Define a data structure for constructing damon_probe's attributes check,
namely damon_filter. It is very similar to damos_filter but works only
for monitoring purposes. Also embed that into damon_probe, implement
essential handling of the link, with fundamental helpers.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
include/linux/damon.h | 36 ++++++++++++++++++++++++++++++++++++
mm/damon/core.c | 30 ++++++++++++++++++++++++++++++
2 files changed, 66 insertions(+)
diff --git a/include/linux/damon.h b/include/linux/damon.h
index dc53bc3da74b3..95b2c508a63ea 100644
--- a/include/linux/damon.h
+++ b/include/linux/damon.h
@@ -730,12 +730,38 @@ struct damon_intervals_goal {
unsigned long max_sample_us;
};
+/**
+ * enum damon_filter_type - Type of &struct damon_filter
+ *
+ * @DAMON_FILTER_TYPE_ANON: Anonymous pages.
+ */
+enum damon_filter_type {
+ DAMON_FILTER_TYPE_ANON,
+};
+
+/**
+ * struct damon_filter - DAMON region filter for &struct damon_probe.
+ *
+ * @type: Type of the region.
+ * @matcing: Whether this filter is for the type-matching ones.
+ * @allow: Whether the @type-@matching ones should pass this filter.
+ * @list: Siblings list.
+ */
+struct damon_filter {
+ enum damon_filter_type type;
+ bool matching;
+ bool allow;
+ struct list_head list;
+};
+
/**
* struct damon_probe - Data region attribute probe.
*
+ * @filters: Filters for assessing if a given region is for this probe.
* @list: Siblings list.
*/
struct damon_probe {
+ struct list_head filters;
struct list_head list;
};
@@ -910,6 +936,12 @@ static inline unsigned long damon_sz_region(struct damon_region *r)
return r->ar.end - r->ar.start;
}
+#define damon_for_each_filter(f, p) \
+ list_for_each_entry(f, &p->filters, list)
+
+#define damon_for_each_filter_safe(f, next, p) \
+ list_for_each_entry_safe(f, next, &p->filters, list)
+
#define damon_for_each_probe(p, ctx) \
list_for_each_entry(p, &ctx->probes, list)
@@ -957,6 +989,10 @@ static inline unsigned long damon_sz_region(struct damon_region *r)
#ifdef CONFIG_DAMON
+struct damon_filter *damon_new_filter(enum damon_filter_type type,
+ bool matching, bool allow);
+void damon_add_filter(struct damon_probe *probe, struct damon_filter *f);
+
struct damon_probe *damon_new_probe(void);
void damon_add_probe(struct damon_ctx *ctx, struct damon_probe *probe);
diff --git a/mm/damon/core.c b/mm/damon/core.c
index 8a55cc61d2972..d01417955a3b4 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -113,6 +113,31 @@ int damon_select_ops(struct damon_ctx *ctx, enum damon_ops_id id)
return err;
}
+struct damon_filter *damon_new_filter(enum damon_filter_type type,
+ bool matching, bool allow)
+{
+ struct damon_filter *filter;
+
+ filter = kmalloc_obj(*filter);
+ if (!filter)
+ return NULL;
+ filter->type = type;
+ filter->matching = matching;
+ filter->allow = allow;
+ INIT_LIST_HEAD(&filter->list);
+ return filter;
+}
+
+void damon_add_filter(struct damon_probe *p, struct damon_filter *f)
+{
+ list_add_tail(&f->list, &p->filters);
+}
+
+static void damon_free_filter(struct damon_filter *f)
+{
+ kfree(f);
+}
+
struct damon_probe *damon_new_probe(void)
{
struct damon_probe *p;
@@ -120,6 +145,7 @@ struct damon_probe *damon_new_probe(void)
p = kmalloc_obj(*p);
if (!p)
return NULL;
+ INIT_LIST_HEAD(&p->filters);
INIT_LIST_HEAD(&p->list);
return p;
}
@@ -136,6 +162,10 @@ static void damon_del_probe(struct damon_probe *p)
static void damon_free_probe(struct damon_probe *p)
{
+ struct damon_filter *f, *next;
+
+ damon_for_each_filter_safe(f, next, p)
+ damon_free_filter(f);
kfree(p);
}
--
2.47.3
next prev parent reply other threads:[~2026-05-12 14:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 14:36 [RFC PATCH v2 00/28] mm/damon: introduce data attributes monitoring SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 01/28] mm/damon/core: introduce struct damon_probe SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 02/28] mm/damon/core: embed damon_probe objects in damon_ctx SeongJae Park
2026-05-12 14:36 ` SeongJae Park [this message]
2026-05-12 14:36 ` [RFC PATCH v2 04/28] mm/damon/core: commit probes SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 05/28] mm/damon/core: introduce damon_region->probe_hits SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 06/28] mm/damon/core: introduce damon_ops->apply_probes SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 07/28] mm/damon/core: do data attributes monitoring SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 08/28] mm/damon/paddr: support " SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 09/28] mm/damon/sysfs: implement probes dir SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 10/28] mm/damon/sysfs: implement probe dir SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 11/28] mm/damon/sysfs: implement filters directory SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 12/28] mm/damon/sysfs: implement filter dir SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 13/28] mm/damon/sysfs: implement filter dir files SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 14/28] mm/damon/sysfs: setup probes on DAMON core API parameters SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 15/28] mm/damon/sysfs-schemes: implement tried_regions/<r>/probes/ SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 16/28] mm/damon/sysfs-schemes: implement probe dir SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 17/28] mm/damon/sysfs-schemes: implement probe/hits file SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 18/28] mm/damon: trace probe_hits SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 19/28] selftests/damon/sysfs.sh: test probes dir SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 20/28] Docs/mm/damon/design: document data attributes monitoring SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 21/28] Docs/admin-guide/mm/damon/usage: " SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 22/28] mm/damon/core: introduce DAMON_FILTER_TYPE_MEMCG SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 23/28] mm/damon/paddr: support DAMON_FILTER_TYPE_MEMCG SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 24/28] mm/damon/sysfs: add filters/<F>/path file SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 25/28] mm/damon/sysfs-schemes: move memcg_path_to_id() to sysfs-common SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 26/28] mm/damon/sysfs: setup damon_filter->memcg_id from path SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 27/28] Docs/mm/damon/design: update for memcg damon filter SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 28/28] Docs/admin-guide/mm/damon/usage: " SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512143645.113201-4-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox