Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "WEI-HONG, YE" <1234567weewee457@gmail.com>
To: fedorov.nikita@h-partners.com
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org,
	linux-mm@kvack.org, virtualization@lists.linux.dev
Subject: Re: [RFC PATCH v3 3/7] hq-spinlock: add contention detection
Date: Tue, 12 May 2026 14:49:08 +0000	[thread overview]
Message-ID: <20260512144908.610907-1-1234567weewee457@gmail.com> (raw)
In-Reply-To: <20260415164459.2904963-4-fedorov.nikita@h-partners.com>

Hi,

I may be missing something, but this patch adds
`update_counters_qspinlock()` for remote handoff accounting.

I tried commenting it out locally, and the kernel still built successfully
with `CONFIG_HQSPINLOCKS=y` and `CONFIG_HQSPINLOCKS_DEBUG=y`. I also could
not find a call site for it in the series, so it looks like this helper may
currently be unreferenced.

Is it still needed, or was the call site possibly missed in this RFC version?

Cheers,
Hong


  reply	other threads:[~2026-05-12 14:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-15 16:44 [RFC PATCH v3 0/7] Fedorov Nikita
2026-04-15 16:44 ` [RFC PATCH v3 1/7] kernel: add hq-spinlock types Fedorov Nikita
2026-04-15 16:44 ` [RFC PATCH v3 2/7] hq-spinlock: implement inner logic Fedorov Nikita
2026-04-15 16:44 ` [RFC PATCH v3 3/7] hq-spinlock: add contention detection Fedorov Nikita
2026-05-12 14:49   ` WEI-HONG, YE [this message]
2026-05-12 16:25     ` Fedorov Nikita
2026-05-12 16:25       ` [PATCH v3] locking/hqlock_core: restore missing call in contention detection logic Fedorov Nikita
2026-04-15 16:44 ` [RFC PATCH v3 4/7] hq-spinlock: add hq-spinlock tunables and debug statistics Fedorov Nikita
2026-04-15 16:44 ` [RFC PATCH v3 5/7] kernel: introduce general hq-spinlock support Fedorov Nikita
2026-04-15 16:44 ` [RFC PATCH v3 6/7] lockref: use hq-spinlock Fedorov Nikita
2026-04-15 16:44 ` [RFC PATCH v3 7/7] futex: use hq-spinlock for hash buckets Fedorov Nikita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260512144908.610907-1-1234567weewee457@gmail.com \
    --to=1234567weewee457@gmail.com \
    --cc=fedorov.nikita@h-partners.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox