From: Andrew Morton <akpm@linux-foundation.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Frederick Mayle <fmayle@google.com>,
android-mm@google.com, kernel-team@android.com,
Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/readahead: add kerneldoc for read_pages
Date: Tue, 12 May 2026 19:14:41 -0700 [thread overview]
Message-ID: <20260512191441.c535e288077895b127a5794f@linux-foundation.org> (raw)
In-Reply-To: <agOWHm00w2vlh1_o@casper.infradead.org>
On Tue, 12 May 2026 22:05:34 +0100 Matthew Wilcox <willy@infradead.org> wrote:
> On Tue, May 12, 2026 at 01:31:35PM -0700, Frederick Mayle wrote:
> > Formalize one of the invariants provided by the current implementation
> > so that callers can depend on it, as discussed in [1].
>
> We don't normally write kerneldoc for static functions. I'm not sure
> why Andrew told you to do this. I have no objection to adding
> documentation, but I don't think it should be marked as kerneldoc.
> And if it's not kerneldoc, it doesn't have to be written in such a
> stifling style.
I'm OK either way. The main point here is that [2/2] relies on
unobvious and possibly fragile behaviour of read_pages().
next prev parent reply other threads:[~2026-05-13 2:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 20:31 [PATCH 0/2] mm: document read_pages and simplify usage Frederick Mayle
2026-05-12 20:31 ` [PATCH 1/2] mm/readahead: add kerneldoc for read_pages Frederick Mayle
2026-05-12 21:05 ` Matthew Wilcox
2026-05-13 2:14 ` Andrew Morton [this message]
2026-05-12 20:31 ` [PATCH 2/2] mm/readahead: simplify page_cache_ra_unbounded loop counter reset Frederick Mayle
2026-05-12 20:37 ` [PATCH 0/2] mm: document read_pages and simplify usage Frederick Mayle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512191441.c535e288077895b127a5794f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=android-mm@google.com \
--cc=fmayle@google.com \
--cc=jack@suse.cz \
--cc=kernel-team@android.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox