From: SeongJae Park <sj@kernel.org>
To: Ye Liu <ye.liu@linux.dev>
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ye Liu <liuye@kylinos.cn>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] tools/mm/page-types: Fix ternary operator precedence in sigbus handler
Date: Wed, 13 May 2026 17:53:14 -0700 [thread overview]
Message-ID: <20260514005314.148447-1-sj@kernel.org> (raw)
In-Reply-To: <20260513022120.58033-3-ye.liu@linux.dev>
On Wed, 13 May 2026 10:21:17 +0800 Ye Liu <ye.liu@linux.dev> wrote:
> From: Ye Liu <liuye@kylinos.cn>
>
> The ternary operator (?:) has lower precedence than addition (+), so
> the expression `off + sigbus_addr ? sigbus_addr - ptr : 0` was parsed
> as `(off + sigbus_addr) ? (sigbus_addr - ptr) : 0` rather than the
> intended `off + (sigbus_addr ? sigbus_addr - ptr : 0)`. Add explicit
> parentheses to ensure the correct evaluation order.
>
> Signed-off-by: Ye Liu <liuye@kylinos.cn>
Acked-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
[...]
next prev parent reply other threads:[~2026-05-14 0:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 2:21 [PATCH 0/3] tools/mm/page-types: Fix misc bugs Ye Liu
2026-05-13 2:21 ` [PATCH 1/3] tools/mm/page-types: Fix typo in madvise() error message Ye Liu
2026-05-13 10:18 ` David Hildenbrand (Arm)
2026-05-14 0:23 ` SeongJae Park
2026-05-13 2:21 ` [PATCH 2/3] tools/mm/page-types: Fix ternary operator precedence in sigbus handler Ye Liu
2026-05-13 10:24 ` David Hildenbrand (Arm)
2026-05-14 0:53 ` SeongJae Park [this message]
2026-05-13 2:21 ` [PATCH 3/3] tools/mm/page-types: Fix kpageflags option argument in getopt_long Ye Liu
2026-05-13 10:27 ` David Hildenbrand (Arm)
2026-05-14 0:57 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514005314.148447-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuye@kylinos.cn \
--cc=ye.liu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox