Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Steven Rostedt <rostedt@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
	"Liam R. Howlett" <liam@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org, Alice Ryhl <aliceryhl@google.com>,
	Andrew Ballance <andrewjballance@gmail.com>,
	maple-tree@lists.infradead.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v2] maple_tree: document that "last" in mtree_insert_range() is inclusive
Date: Thu, 14 May 2026 07:23:11 -0700	[thread overview]
Message-ID: <20260514142311.119947-1-sj@kernel.org> (raw)
In-Reply-To: <20260514100723.4af0d7ba@gandalf.local.home>

On Thu, 14 May 2026 10:07:23 -0400 Steven Rostedt <rostedt@kernel.org> wrote:

> On Wed, 13 May 2026 18:42:04 -0700
> SeongJae Park <sj@kernel.org> wrote:
> 
> > >  /**
> > > - * mtree_insert_range() - Insert an entry at a given range if there is no value.
> > > + * mtree_insert_range() - Insert an entry from [first, last] at a given range
> > > + *                        if there is no value.  
> > 
> > It feels "at a given range" bit repetitive to me.  s/at a given range// ?
> > 
> 
> I just added what Liam suggested.

Liam's suggestion was very sligtly different.

: Something like this:
:
: mtree_insert_range() - Insert an entry from [first, last] if there isn't
: an entry within that range.

So I assumed you intentionally reworded it, but might forgot erasing 'at a
given range'.  English is never my mother tongue language, but Geminit also
told me dropping 'at a given range' makes it bit easier to read.  Hence I just
wanted to check if this is intentional.

> Should I send a v3?

The current wording works for me.  English is never my mother tongue langauage,
so I cannot judge.  I just wanted to make sure this is the intended change.  So
I will leave the decision to you and others.

If we decide to rewording, I think Andrew could help without asking you to
resned v3 for such a minor change.


Thanks,
SJ

[...]


      reply	other threads:[~2026-05-14 14:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 21:56 [PATCH v2] maple_tree: document that "last" in mtree_insert_range() is inclusive Steven Rostedt
2026-05-13  0:40 ` Liam R. Howlett
2026-05-14  1:42 ` SeongJae Park
2026-05-14 14:07   ` Steven Rostedt
2026-05-14 14:23     ` SeongJae Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260514142311.119947-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=aliceryhl@google.com \
    --cc=andrewjballance@gmail.com \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=rostedt@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox