From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: "David Hildenbrand (Arm)" <david@kernel.org>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Muchun Song" <muchun.song@linux.dev>,
"Oscar Salvador" <osalvador@suse.de>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Lorenzo Stoakes" <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
"Vlastimil Babka" <vbabka@kernel.org>,
"Mike Rapoport" <rppt@kernel.org>,
"Suren Baghdasaryan" <surenb@google.com>,
"Michal Hocko" <mhocko@suse.com>,
"Brendan Jackman" <jackmanb@google.com>,
"Johannes Weiner" <hannes@cmpxchg.org>, "Zi Yan" <ziy@nvidia.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Nico Pache" <npache@redhat.com>,
"Ryan Roberts" <ryan.roberts@arm.com>,
"Dev Jain" <dev.jain@arm.com>, "Barry Song" <baohua@kernel.org>,
"Lance Yang" <lance.yang@linux.dev>,
"Hugh Dickins" <hughd@google.com>,
"Matthew Brost" <matthew.brost@intel.com>,
"Joshua Hahn" <joshua.hahnjy@gmail.com>,
"Rakie Kim" <rakie.kim@sk.com>,
"Byungchul Park" <byungchul@sk.com>,
"Gregory Price" <gourry@gourry.net>,
"Ying Huang" <ying.huang@linux.alibaba.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Christoph Lameter" <cl@gentwo.org>,
"David Rientjes" <rientjes@google.com>,
"Roman Gushchin" <roman.gushchin@linux.dev>,
"Harry Yoo" <harry.yoo@oracle.com>,
"Axel Rasmussen" <axelrasmussen@google.com>,
"Yuanchu Xie" <yuanchu@google.com>, "Wei Xu" <weixugc@google.com>,
"Chris Li" <chrisl@kernel.org>,
"Kairui Song" <kasong@tencent.com>,
"Kemeng Shi" <shikemeng@huaweicloud.com>,
"Nhat Pham" <nphamcs@gmail.com>, "Baoquan He" <bhe@redhat.com>,
virtualization@lists.linux.dev, linux-mm@kvack.org,
"Andrea Arcangeli" <aarcange@redhat.com>
Subject: Re: [PATCH v9 00/37] mm/virtio: skip redundant zeroing of host-zeroed pages
Date: Mon, 1 Jun 2026 08:13:56 -0400 [thread overview]
Message-ID: <20260601080712-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <cover.1780067977.git.mst@redhat.com>
I went over sashiko review of this:
https://sashiko.dev/#/patchset/cover.1780067977.git.mst%40redhat.com
It's mostly Sashiko apparently not seeing the whole picture
(e.g. is says "an optimization is missing" and it is actually
added in follow up patches).
Sometimes it is unhappy while there's an explanation right in the commit
log. Weird.
It's a pity there's no way to respond to the review, to make it pay more
attention and reconsider.
It did flag a minor rebase artifact (declaration landed in the wrong
patch during rebase). Mostly harmless but if there's a v10, I'll fix that.
But it also flagged 4 pre-existing bugs:
- page_reporting_register before DRIVER_OK, theoretical race in virtballoon_probe ordering:
https://sashiko.dev/#/patchset/cover.1780067977.git.mst%40redhat.com?part=4
- spurious OOM on large-folio swapin race in do_swap_page:
https://sashiko.dev/#/patchset/cover.1780067977.git.mst%40redhat.com?part=16
- free_huge_folio called with refcount==1 on mem_cgroup_charge_hugetlb failure:
https://sashiko.dev/#/patchset/cover.1780067977.git.mst%40redhat.com?part=20
- double-decrement of resv_huge_pages in memfd_alloc_folio error path:
https://sashiko.dev/#/patchset/cover.1780067977.git.mst%40redhat.com?part=21
All seem unrelated to the specific feature, so I'd rather put off fixing
these until the feature is merged.
--
MST
prev parent reply other threads:[~2026-06-01 12:14 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 22:20 [PATCH v8 00/37] mm/virtio: skip redundant zeroing of host-zeroed pages Michael S. Tsirkin
2026-05-20 22:20 ` [PATCH v8 01/37] mm: mempolicy: fix interleave index for unaligned VMA start Michael S. Tsirkin
2026-05-20 22:20 ` [PATCH v8 02/37] mm: memory-failure: serialize TestSetPageHWPoison with zone->lock Michael S. Tsirkin
2026-05-20 22:20 ` [PATCH v8 03/37] mm: page_alloc: propagate PageReported flag across buddy splits Michael S. Tsirkin
2026-05-20 22:20 ` [PATCH v8 04/37] mm: page_reporting: allow driver to set batch capacity Michael S. Tsirkin
2026-05-20 22:20 ` [PATCH v8 05/37] mm: hugetlb: remove dead alloc_hugetlb_folio stub Michael S. Tsirkin
2026-05-20 22:20 ` [PATCH v8 06/37] mm: move vma_alloc_folio_noprof to page_alloc.c Michael S. Tsirkin
2026-05-20 22:20 ` [PATCH v8 07/37] mm: thread user_addr through page allocator for cache-friendly zeroing Michael S. Tsirkin
2026-05-20 22:21 ` [PATCH v8 08/37] mm: add alloc_contig_frozen_pages_user " Michael S. Tsirkin
2026-05-20 22:21 ` [PATCH v8 09/37] mm: hugetlb: thread user_addr through gigantic page allocation Michael S. Tsirkin
2026-05-20 22:21 ` [PATCH v8 10/37] mm: add folio_zero_user stub for configs without THP/HUGETLBFS Michael S. Tsirkin
2026-05-20 22:21 ` [PATCH v8 11/37] mm: page_alloc: move prep_compound_page before post_alloc_hook Michael S. Tsirkin
2026-05-20 22:21 ` [PATCH v8 12/37] mm: use folio_zero_user for user pages in post_alloc_hook Michael S. Tsirkin
2026-05-20 22:21 ` [PATCH v8 13/37] mm: use __GFP_ZERO in vma_alloc_zeroed_movable_folio Michael S. Tsirkin
2026-05-20 22:21 ` [PATCH v8 14/37] mm: remove arch vma_alloc_zeroed_movable_folio overrides Michael S. Tsirkin
2026-05-20 22:21 ` [PATCH v8 15/37] mm: alloc_anon_folio: pass raw fault address to vma_alloc_folio Michael S. Tsirkin
2026-05-20 22:21 ` [PATCH v8 16/37] mm: alloc_swap_folio: " Michael S. Tsirkin
2026-05-20 22:21 ` [PATCH v8 17/37] mm: use __GFP_ZERO in alloc_anon_folio Michael S. Tsirkin
2026-05-20 22:22 ` [PATCH v8 18/37] mm: vma_alloc_anon_folio_pmd: pass raw fault address to vma_alloc_folio Michael S. Tsirkin
2026-05-20 22:22 ` [PATCH v8 19/37] mm: use __GFP_ZERO in vma_alloc_anon_folio_pmd Michael S. Tsirkin
2026-05-20 22:22 ` [PATCH v8 20/37] mm: hugetlb: add gfp parameter and skip zeroing for zeroed pages Michael S. Tsirkin
2026-05-20 22:22 ` [PATCH v8 21/37] mm: memfd: skip zeroing for zeroed hugetlb pool pages Michael S. Tsirkin
2026-05-20 22:22 ` [PATCH v8 22/37] mm: page_reporting: skip redundant zeroing of host-zeroed reported pages Michael S. Tsirkin
2026-05-20 22:22 ` [PATCH v8 23/37] mm: page_alloc: use aliasing checks instead of user_alloc_needs_zeroing Michael S. Tsirkin
2026-05-20 22:22 ` [PATCH v8 24/37] mm: page_reporting: add per-page zeroed bitmap for host feedback Michael S. Tsirkin
2026-05-20 22:22 ` [PATCH v8 25/37] mm: page_alloc: clear PG_zeroed on buddy merge if not both zero Michael S. Tsirkin
2026-05-20 22:22 ` [PATCH v8 26/37] mm: page_alloc: preserve PG_zeroed in page_del_and_expand Michael S. Tsirkin
2026-05-20 22:22 ` [PATCH v8 27/37] virtio_balloon: submit reported pages as individual buffers Michael S. Tsirkin
2026-05-20 22:22 ` [PATCH v8 28/37] virtio_balloon: disable indirect descriptors Michael S. Tsirkin
2026-05-20 22:22 ` [PATCH v8 29/37] mm: page_reporting: add flush parameter with page budget Michael S. Tsirkin
2026-05-20 22:23 ` [PATCH v8 30/37] mm: page_alloc: propagate PG_zeroed in split_large_buddy Michael S. Tsirkin
2026-05-20 22:23 ` [PATCH v8 31/37] virtio_balloon: skip zeroing for host-zeroed reported pages Michael S. Tsirkin
2026-05-20 22:23 ` [PATCH v8 32/37] virtio_balloon: disable reporting zeroed optimization for confidential guests Michael S. Tsirkin
2026-05-20 22:23 ` [PATCH v8 33/37] mm: add free_frozen_pages_zeroed Michael S. Tsirkin
2026-05-20 22:23 ` [PATCH v8 34/37] mm: page_alloc: skip kernel_init_pages for FPI_ZEROED when safe Michael S. Tsirkin
2026-05-20 22:23 ` [PATCH v8 35/37] mm: add put_page_zeroed and folio_put_zeroed Michael S. Tsirkin
2026-05-20 22:23 ` [PATCH v8 36/37] virtio_balloon: implement VIRTIO_BALLOON_F_DEVICE_INIT_ON_INFLATE Michael S. Tsirkin
2026-05-20 22:23 ` [PATCH v8 37/37] mm: balloon: use put_page_zeroed for zeroed balloon pages Michael S. Tsirkin
2026-05-21 14:09 ` [PATCH v8 00/37] mm/virtio: skip redundant zeroing of host-zeroed pages Michael S. Tsirkin
2026-05-27 3:23 ` Miaohe Lin
2026-05-27 5:25 ` Michael S. Tsirkin
2026-05-27 6:40 ` Miaohe Lin
2026-05-29 15:22 ` [PATCH v9 " Michael S. Tsirkin
2026-05-29 15:22 ` [PATCH v9 01/37] mm: mempolicy: fix interleave index calculation Michael S. Tsirkin
2026-05-29 15:22 ` [PATCH v9 02/37] mm: memory-failure: serialize TestSetPageHWPoison with zone->lock Michael S. Tsirkin
2026-06-01 7:17 ` Miaohe Lin
2026-05-29 15:22 ` [PATCH v9 03/37] mm: page_alloc: propagate PageReported flag across buddy splits Michael S. Tsirkin
2026-05-29 15:22 ` [PATCH v9 04/37] mm: page_reporting: allow driver to set batch capacity Michael S. Tsirkin
2026-05-29 15:22 ` [PATCH v9 05/37] mm: hugetlb: remove dead alloc_hugetlb_folio stub Michael S. Tsirkin
2026-06-01 6:55 ` Dev Jain
2026-05-29 15:22 ` [PATCH v9 06/37] mm: move vma_alloc_folio_noprof to page_alloc.c Michael S. Tsirkin
2026-05-29 15:22 ` [PATCH v9 07/37] mm: thread user_addr through page allocator for cache-friendly zeroing Michael S. Tsirkin
2026-06-01 12:06 ` Michael S. Tsirkin
2026-05-29 15:22 ` [PATCH v9 08/37] mm: add alloc_contig_frozen_pages_user " Michael S. Tsirkin
2026-05-29 15:22 ` [PATCH v9 09/37] mm: hugetlb: thread user_addr through gigantic page allocation Michael S. Tsirkin
2026-05-29 15:22 ` [PATCH v9 10/37] mm: add folio_zero_user stub for configs without THP/HUGETLBFS Michael S. Tsirkin
2026-05-29 15:22 ` [PATCH v9 11/37] mm: page_alloc: move prep_compound_page before post_alloc_hook Michael S. Tsirkin
2026-05-29 15:23 ` [PATCH v9 12/37] mm: use folio_zero_user for user pages in post_alloc_hook Michael S. Tsirkin
2026-05-29 15:23 ` [PATCH v9 13/37] mm: use __GFP_ZERO in vma_alloc_zeroed_movable_folio Michael S. Tsirkin
2026-05-29 15:23 ` [PATCH v9 14/37] mm: remove arch vma_alloc_zeroed_movable_folio overrides Michael S. Tsirkin
2026-05-29 15:23 ` [PATCH v9 15/37] mm: alloc_anon_folio: pass raw fault address to vma_alloc_folio Michael S. Tsirkin
2026-05-29 15:23 ` [PATCH v9 16/37] mm: alloc_swap_folio: " Michael S. Tsirkin
2026-05-29 15:23 ` [PATCH v9 17/37] mm: use __GFP_ZERO in alloc_anon_folio Michael S. Tsirkin
2026-05-29 15:23 ` [PATCH v9 18/37] mm: vma_alloc_anon_folio_pmd: pass raw fault address to vma_alloc_folio Michael S. Tsirkin
2026-05-29 15:23 ` [PATCH v9 19/37] mm: use __GFP_ZERO in vma_alloc_anon_folio_pmd Michael S. Tsirkin
2026-05-29 15:24 ` [PATCH v9 20/37] mm: hugetlb: add gfp parameter and skip zeroing for zeroed pages Michael S. Tsirkin
2026-05-29 15:24 ` [PATCH v9 21/37] mm: memfd: skip zeroing for zeroed hugetlb pool pages Michael S. Tsirkin
2026-05-29 15:24 ` [PATCH v9 22/37] mm: page_reporting: skip redundant zeroing of host-zeroed reported pages Michael S. Tsirkin
2026-05-29 15:24 ` [PATCH v9 23/37] mm: page_alloc: use aliasing checks instead of user_alloc_needs_zeroing Michael S. Tsirkin
2026-05-29 15:24 ` [PATCH v9 24/37] mm: page_reporting: add per-page zeroed bitmap for host feedback Michael S. Tsirkin
2026-05-29 15:24 ` [PATCH v9 25/37] mm: page_alloc: clear PG_zeroed on buddy merge if not both zero Michael S. Tsirkin
2026-05-29 15:24 ` [PATCH v9 26/37] mm: page_alloc: preserve PG_zeroed in page_del_and_expand Michael S. Tsirkin
2026-05-29 15:24 ` [PATCH v9 27/37] virtio_balloon: submit reported pages as individual buffers Michael S. Tsirkin
2026-05-29 15:24 ` [PATCH v9 28/37] virtio_balloon: disable indirect descriptors Michael S. Tsirkin
2026-05-29 15:24 ` [PATCH v9 29/37] mm: page_reporting: add flush parameter with page budget Michael S. Tsirkin
2026-05-29 15:24 ` [PATCH v9 30/37] mm: page_alloc: propagate PG_zeroed in split_large_buddy Michael S. Tsirkin
2026-05-29 15:24 ` [PATCH v9 31/37] virtio_balloon: skip zeroing for host-zeroed reported pages Michael S. Tsirkin
2026-05-29 15:25 ` [PATCH v9 32/37] virtio_balloon: disable reporting zeroed optimization for confidential guests Michael S. Tsirkin
2026-05-29 15:25 ` [PATCH v9 33/37] mm: add free_frozen_pages_zeroed Michael S. Tsirkin
2026-05-29 15:25 ` [PATCH v9 34/37] mm: page_alloc: skip kernel_init_pages for FPI_ZEROED when safe Michael S. Tsirkin
2026-05-29 15:25 ` [PATCH v9 35/37] mm: add put_page_zeroed and folio_put_zeroed Michael S. Tsirkin
2026-05-29 15:25 ` [PATCH v9 36/37] mm: balloon: use put_page_zeroed for zeroed balloon pages Michael S. Tsirkin
2026-05-29 15:25 ` [PATCH v9 37/37] virtio_balloon: implement VIRTIO_BALLOON_F_DEVICE_INIT_ON_INFLATE Michael S. Tsirkin
2026-06-01 12:13 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260601080712-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=bhe@redhat.com \
--cc=byungchul@sk.com \
--cc=chrisl@kernel.org \
--cc=cl@gentwo.org \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=eperezma@redhat.com \
--cc=gourry@gourry.net \
--cc=hannes@cmpxchg.org \
--cc=harry.yoo@oracle.com \
--cc=hughd@google.com \
--cc=jackmanb@google.com \
--cc=jasowang@redhat.com \
--cc=joshua.hahnjy@gmail.com \
--cc=kasong@tencent.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=matthew.brost@intel.com \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=npache@redhat.com \
--cc=nphamcs@gmail.com \
--cc=osalvador@suse.de \
--cc=rakie.kim@sk.com \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shikemeng@huaweicloud.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=weixugc@google.com \
--cc=xuanzhuo@linux.alibaba.com \
--cc=ying.huang@linux.alibaba.com \
--cc=yuanchu@google.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox