From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BC9FCD6E4A for ; Tue, 2 Jun 2026 13:05:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB8DB6B03BB; Tue, 2 Jun 2026 09:04:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B90146B03BC; Tue, 2 Jun 2026 09:04:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA5DA6B03BD; Tue, 2 Jun 2026 09:04:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9D6AE6B03BB for ; Tue, 2 Jun 2026 09:04:59 -0400 (EDT) Received: from smtpin30.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 519AE1C0FBF for ; Tue, 2 Jun 2026 13:04:59 +0000 (UTC) X-FDA: 84834992718.30.02E91A6 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf02.hostedemail.com (Postfix) with ESMTP id 4BA2080019 for ; Tue, 2 Jun 2026 13:04:57 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20251104 header.b=WJsb6lQD; spf=pass (imf02.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1780405497; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H/8nMdqnIqVIuE86ZCCEmz0EQ1iXOszPXfKX9VZoGH4=; b=QP4PWok5b27Ru+QbTgQsSzjK64kDooE9zCb2JS7UXYAvdhL1AXGn3QXvIZyt08C0lJ9PQw BFFwBr5HrfxkKAaQekpvLk0z3rj1qwLt8qspaqe4bx5j4j7UXRq/C74xNVlhMbL6HxdC+5 F07BKjE5jg6yvdSxNOHqpVqQxlqqTUo= ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1780405497; b=KBFxJlhcOEsRxc2NfkrH/yzbUypfylRu7Dq3dDijGA+kHovXNamFMp6dBxhA4K3tLFWNds bnKLFol7+CO834hBwDS/5jfAH6ixk+iwBwK5xfjKo+SCUnKZ9yp4E2fg/uaFSEDszhHAq/ qYE53k61cJ+b3RpMgqfOzkpbbPSBym0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20251104 header.b=WJsb6lQD; spf=pass (imf02.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4906238c62eso93031365e9.3 for ; Tue, 02 Jun 2026 06:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780405496; x=1781010296; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=H/8nMdqnIqVIuE86ZCCEmz0EQ1iXOszPXfKX9VZoGH4=; b=WJsb6lQDnHNKjbfPZ7Gt2D8NeefYSBiNTfdj4T3ExagTULzVm74FsHRJGaR/50aYjh EF4p+GeJ43LnE9iVS32RITYHvj+qzzXafO4TaO921shXnnN2BX9gy09GXYAL1NJ+ZAxG 5wejeU4++bw0rweJVduNuluw2ALqSum6OXfvYZOGeVwS3iP5VEs5G7ZYtzKPofFiywuQ 9QVWIcF9HGlH5DQmTLij/RS7cMJyVFjUjnxxfolXV12dY95blvPyLvRWjBFW3FwVbiRV wiV4VbeTqmXAq48I5uf5tftBTUOF78nNfeGQHV9sEtadtTWS1FAHu/ZdqZguq7Y0TpUT QG1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780405496; x=1781010296; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=H/8nMdqnIqVIuE86ZCCEmz0EQ1iXOszPXfKX9VZoGH4=; b=B86evE02Ed1j006o+7d6OY5og1ntF6KA93rvIA7P9+CRktiv1Izp0vSYuK6iWLBXm3 YmNmxfgBdGregH5wY/ekHhVy3+kJCPM3SbM3S9gTKciZXns/ChfV6FmFRWerEkyLy+2I AweIY4XmCE9m5wxeOGS9048BO+xNs+a2jE+GwZHfdwdIoTIM736nUUBGnXzWeivGVGj7 trJFOq+EgNCrC2q9PHM7WnAW+sW0ltxx9SEmwAwfgtr95uPPaU4oiCyZD/LYfvva2QAq C4ZrKbAF0T9qST7HIXR12Nr4uO2uv8hUGg6SLI5eszCMRAdYYjaaZh3OyhrWEXqKnoMJ HPLA== X-Forwarded-Encrypted: i=1; AFNElJ/wLt4DuM2oo3k5MLqrKisbQC8kSKtvwdlqJqj6UpEHSevS+oAlBX0jmw9lV+OQErQamiR/cfRDJg==@kvack.org X-Gm-Message-State: AOJu0YxdD7AfWcxFO4fq/LPXqXy6DGMpnTQXw7J6JAauFIcPrRpubXec o2TC8chLpydl3P28wGZalW9tN9xZ+5Ay/aRhQgXRu3JZXPvKzfzK2Njb X-Gm-Gg: Acq92OFoYC3ck8pnO6B6K0CIRpGo56yFJ9SLFn9TBwc9kHUl5vu8bQvu7y6o7RHp0Wi ITJijQSTlvIXcIBCj+wJn1m96TUw7Xc3Zhzs4nDszb61YnjnORklvL9xtGfusp1HbLf2NXUKk5o CD+Tf9HMO53l4ElfXXOCwTXGfTSwJUjEQruU2zmeGRAXd8Sw2AkDmpY0eWw3kzycjsjjfiuHfpH 3zisPfnHviCAH8LZBhgcJqh5GiYreI/6d5w4xEjPcYb6zS8YerKOZht3qO47f2AmbQ0yj0at5R5 jWN6Mjosf3ibeK0fgeGTZtEfQ+n6QRileXQ3eg3LBMYWuJGMsYlmsd5IUtXEiX4JPBbZ19u2/l4 9d6udfG27KrOKyYHM7419wTy94BcJoyAokNU05oB6wPo4SvRB0FvRu9k2mA+NjcFUM7eA8T2oTS DNA+pcsHiTfnhEhULc9kI2FTsbzkcEwxK/ehtpuhq8fF41MmsBN44XSzzVt5loYL5H/2XSRQYSs pLPpwAY3A== X-Received: by 2002:a05:600c:8105:b0:490:b072:1be6 with SMTP id 5b1f17b1804b1-490b0721e0amr76565325e9.25.1780405495119; Tue, 02 Jun 2026 06:04:55 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef34b834esm33184301f8f.11.2026.06.02.06.04.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 06:04:54 -0700 (PDT) Date: Tue, 2 Jun 2026 14:04:51 +0100 From: David Laight To: Andy Shevchenko Cc: Kees Cook , Luis Chamberlain , Pengpeng Hou , stable@vger.kernel.org, Petr Pavlu , Richard Weinberger , Anton Ivanov , Johannes Berg , "Rafael J. Wysocki" , Len Brown , Corey Minyard , Gabriel Somlo , "Michael S. Tsirkin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Bart Van Assche , Jason Gunthorpe , Leon Romanovsky , Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab , Bjorn Helgaas , Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Greg Kroah-Hartman , Jiri Slaby , Alan Stern , Jason Wang , Xuan Zhuo , Eugenio =?UTF-8?B?UMOpcmV6?= , Jason Baron , Jim Cromie , Tiwei Bie , Benjamin Berg , Ilpo =?UTF-8?B?SsOkcnZpbmVu?= , "David E. Box" , "Maciej W. Rozycki" , Srinivas Pandruvada , Peter Zijlstra , Heiko Carstens , Vasily Gorbik , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vinod Koul , Frank Li , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Georgia Garcia , kvm@vger.kernel.org, dmaengine@vger.kernel.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, openipmi-developer@lists.sourceforge.net, qemu-devel@nongnu.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 01/11] params: bound array element output to the caller's page buffer Message-ID: <20260602140451.2e3e6622@pumpkin> In-Reply-To: References: <20260521133315.work.845-kees@kernel.org> <20260521133326.2465264-1-kees@kernel.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4BA2080019 X-Rspam-User: X-Stat-Signature: zbgjp1t5cs8yq1uowt9pohq9wdwcya11 X-Rspamd-Server: rspam08 X-HE-Tag: 1780405497-967417 X-HE-Meta: U2FsdGVkX1+2oDyLfL1EF463Itznrhn/j5Eh72AjAqQaD3A9RiOcGy6Yv8GOLV/lhxEyGIE5UFq2L1RKgxvDh0F2fyzmD3rp5hQPDAsZpJk7Tvjionvm8Z48J+t6TFY4YtjjcaI9Ivd0VQMEWCtIqdVZARHxgSTlFgqbAzpNZO0ZVhowSPrlGIatKt4x7KpwdAT2rIZKUzA/r5ycNn6fgI9FGHD3ZxN0sAjnLl7lb6pNSpwC2xzxa2vT/r4kuXzXvHbnTbbFmJSFN+mjvTRKVnL0kAz0OzAYCu5NciAEOPHfbBazrLeQ18CLkfB1WexIN93/NI5ZPp4+g2+UJ1i8nwCEWD3v4EjMA9fhPjKpNK7yQRIqLbB7IeD+1KQgEtNfP9EL2AQ9fHP49z1YIRuwvHQdCOttX3Q85piqaxOspBhz4nYfIQ0wVGFfRJDE4Elr0OaoypDSQ2NyBQ4dMaWoeKnWhcjVLcIHbnUVL6EfJNmW8kD1PJGrlDEW0OM8bAyz90gCV0Xfo3OE7eLRyE7FIvMiL2aQ9yzzEMI2WgkT7brdqjEuD20h1NeiIZnt8GPzQO2U0nZc+9j2Ijfkw/WqHXDq+BRisnjXShcKIOwouXskXKNnUlNmnkENFeYMdahBH4zBMmaX2Ulv8drebjpCLccW0+X4AI16GEl3oJ3CIGfoyFHLMOBig0R3XPYmbmfp45Hd6DIUTpL7Vv0cdqajy4GpEECHb0s3eFIkeI3jUTEv++8tL/Q2xNJiXY5CDW2R1KLP5fuiGDGKA8kLQclq2lCxHiN3M0w2KlkMyfvhGKP28jNYpzNJ1dV6OQ0w+1pQa2PcVWxIMXmHwlJFK6U9cJsud6Z9gCHcscnYj+ngHPauJ/ObQlLBiiRl7j0X5RS10d7jem0z3xx2BxzZgq/QSKNRZTTQFfrGxDswhG5HUN3U+lCgO645XeFzk19gJd6TgidhIi1fzOePhVhe37u wWw/UUEc 76vjxBndWRh0BYPG464m5C9VMXFAPFaFNw/TzUih4TYi4aitudFZGS2no8rcknKSgFBQ3lKy+2bNMjPhm+HggeRFDOqiM6N2QV/tcUClKPW68G31DPFPxDMyczp698cC+PNWHewdSQYWl/I8gKrRqR/bG1IvFB2qoPFcdoLJbBWim7hbsdf8eHUxk0kgdxsztLVTE6hHKgOs3ZZBAaxwffMBozOIbRwEF6bvPNi3L6TstOlrYAdxtYO3iKJHS6cwi/6M9X4l/gyD2x9yIbmZrJ0mMOTaGpzjb2OabhkXs7YDoTwJqxmAuXfI5LGtV+EObhfvbc16giAhM4zX73NvXcpoBmWoJNPQDX1WuavapmYe3c+QdmQBLLxdBewK0OgdBVKZtB9quYX0nsGVo3GZlQFDkcKJ500/TLsBEzt8cZlsUOqIXhzEDJGbj77C6KMDYvIN4fKxlMNHUoee4RuBvaMfAwuVi9PBhB81fjMgSc0DpOaqlw7ZqO/noMQ== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 2 Jun 2026 14:26:46 +0300 Andy Shevchenko wrote: > On Thu, May 21, 2026 at 06:33:14AM -0700, Kees Cook wrote: > > > > param_array_get() appends each element's string representation into the > > shared sysfs page buffer by passing buffer + off to the element getter. > > > > That works for getters that only write a small bounded string, but > > param_get_charp() and similar helpers format against PAGE_SIZE from the > > pointer they receive. Once off is non-zero, an element getter can > > therefore write past the end of the original sysfs page buffer. > > > > Collect each element into a temporary PAGE_SIZE buffer first and then > > copy only the remaining space into the caller's page buffer. > > ... > > > + elem_buf = kmalloc(PAGE_SIZE, GFP_KERNEL); > > get_free_page() (or how it is called)? The kmalloc() should be faster and I think has to be aligned. There is another patch set to replace get_free_pages() with kmalloc(). Although all these 'show' functions should really head to using a safer interface. Although, at the moment, it is really difficult to find the ones that are guaranteed to be passed a page aligned buffer. -- David > > > + if (!elem_buf) > > + return -ENOMEM; > > + > > for (i = off = 0; i < (arr->num ? *arr->num : arr->max); i++) { > > - /* Replace \n with comma */ > > - if (i) > > - buffer[off - 1] = ','; > > p.arg = arr->elem + arr->elemsize * i; > > check_kparam_locked(p.mod); > > - ret = arr->ops->get(buffer + off, &p); > > + ret = arr->ops->get(elem_buf, &p); > > if (ret < 0) > > - return ret; > > + goto out; > > + ret = min(ret, (int)(PAGE_SIZE - 1 - off)); > > It's usually discouraged to use castings in min/max/clamp. Can we make ret long > or do something different here? > > > + if (!ret) > > + break; > > > + /* Replace the previous element's trailing newline with a comma. */ > > + if (i) > > + buffer[off - 1] = ','; > > Can't we do this after with help of strreplace()? > > > + memcpy(buffer + off, elem_buf, ret); > > off += ret; > > + if (off == PAGE_SIZE - 1) > > + break; > > } > > buffer[off] = '\0'; > > - return off; > > + ret = off; > > +out: > > + kfree(elem_buf); > > + return ret; >