Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Ruslan Valiyev <linuxoid@gmail.com>
Cc: SeongJae Park <sj@kernel.org>, Shuah Khan <shuah@kernel.org>,
	damon@lists.linux.dev, linux-mm@kvack.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] selftests/damon/_damon_sysfs: support kdamond refresh_ms
Date: Tue,  2 Jun 2026 07:13:49 -0700	[thread overview]
Message-ID: <20260602141350.101848-1-sj@kernel.org> (raw)
In-Reply-To: <20260602131217.2210912-2-linuxoid@gmail.com>

On Tue,  2 Jun 2026 15:12:16 +0200 Ruslan Valiyev <linuxoid@gmail.com> wrote:

> The Kdamond class has no way to set the kdamond-level 'refresh_ms' sysfs
> file, which makes DAMON periodically update the read-only sysfs files
> (DAMOS stats, tuned monitoring intervals and the kdamond pid) on its own.
> 
> Add a 'refresh_ms' parameter to Kdamond.  When it is set (including to
> zero, to disable the periodic update), write it before turning the
> kdamond on, so tests can exercise the auto-update behavior.  Leaving it
> unset keeps the previous behavior of not touching the file, so callers
> running against kernels without the feature are unaffected.

Nice addition of the feature, thank you!

> 
> Signed-off-by: Ruslan Valiyev <linuxoid@gmail.com>

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

[...]


  reply	other threads:[~2026-06-02 14:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02 13:12 [PATCH 0/2] selftests/damon: test kdamond refresh_ms Ruslan Valiyev
2026-06-02 13:12 ` [PATCH 1/2] selftests/damon/_damon_sysfs: support " Ruslan Valiyev
2026-06-02 14:13   ` SeongJae Park [this message]
2026-06-02 13:12 ` [PATCH 2/2] selftests/damon/sysfs_refresh: test " Ruslan Valiyev
2026-06-02 14:23   ` SeongJae Park
2026-06-02 14:28 ` [PATCH 0/2] selftests/damon: " SeongJae Park
2026-06-02 17:03   ` Andrew Morton
2026-06-03  0:50     ` SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260602141350.101848-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxoid@gmail.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox