From: SeongJae Park <sj@kernel.org>
To: "Kunwu Chan" <kunwu.chan@linux.dev>
Cc: SeongJae Park <sj@kernel.org>,
shuah@kernel.org, damon@lists.linux.dev,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, "Kunwu Chan" <chentao@kylinos.cn>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 0/3] selftests/damon: misc fixes for test bugs
Date: Tue, 2 Jun 2026 22:02:17 -0700 [thread overview]
Message-ID: <20260603050219.91743-1-sj@kernel.org> (raw)
In-Reply-To: <38c4d77974349f9783478a04c46df6f975d41c84@linux.dev>
On Wed, 03 Jun 2026 02:11:33 +0000 "Kunwu Chan" <kunwu.chan@linux.dev> wrote:
> 2026年6月1日 22:22, "SeongJae Park" <sj@kernel.org mailto:sj@kernel.org?to=%22SeongJae%20Park%22%20%3Csj%40kernel.org%3E > 写到:
>
>
> >
> > On Mon, 1 Jun 2026 11:23:11 +0800 Kunwu Chan <kunwu.chan@linux.dev> wrote:
> >
> > >
> > > From: Kunwu Chan <chentao@kylinos.cn>
> > >
> > > This series fixes several bugs in the DAMON selftests. Most are
> > > trivial but cause tests to silently pass when they shouldn't, or
> > > fail prematurely on slow machines.
> > >
> > Nit. Only patch 3 fixes a fake test pass for "avail_operations" file existence
> > test, and the series is not doing something for slow machines, right? I think
> > the last sentence should be updated, for example:
> >
> > '''
> > Most are trivial but makes test output wrong or even silently pass the one for
> > 'avail_operation' file existence check.
> > '''
> >
> > Other than that, all look good to me, and already have my Reviewed-by: tag.
> >
> > Asssuming you are ok with the above change, I applied this series to damon/next
> > [1] tree with the above change. If this series is not added to mm.git in short
> > term (~1 week?), I will ask mm.git maintainer (Andrew Morton) to pick this.
FYI, we are now quite close to next merge window. We want to focus on making
mm.git more stabilized and therefore ready for the next merge window, rather
than adding more changes that no really urgent. I understand this series is
not really urgent. Hence, I will request adding this to mm.git after next -rc1
release. Let me know if you think this is really urgent.
> > So, no action from your side is needed for now. If it seems I also forgot
> > doing that or you cannot wait for my action, please feel free to directly ask
> > that to Andrew.
> >
> > [1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees
> >
> Hi SJ,
>
> The updated cover letter looks good to me, thanks for fixing it.
> Thanks also for applying to damon/next.
> No further action needed on my side.
Thank you for confirming!
Thanks,
SJ
[...]
next prev parent reply other threads:[~2026-06-03 5:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 3:23 [PATCH v2 0/3] selftests/damon: misc fixes for test bugs Kunwu Chan
2026-06-01 3:23 ` [PATCH v2 1/3] selftests/damon: prevent cross-context state pollution in DamonCtx Kunwu Chan
2026-06-01 3:23 ` [PATCH v2 2/3] selftests/damon/damos_tried_regions: fix expectation output and join TypeError Kunwu Chan
2026-06-01 3:23 ` [PATCH v2 3/3] selftests/damon: fix dead code, skipped checks, and broken lookups Kunwu Chan
2026-06-01 14:22 ` [PATCH v2 0/3] selftests/damon: misc fixes for test bugs SeongJae Park
2026-06-03 2:11 ` Kunwu Chan
2026-06-03 5:02 ` SeongJae Park [this message]
2026-06-03 9:15 ` Kunwu Chan
2026-06-01 14:28 ` SeongJae Park
2026-06-03 2:06 ` Kunwu Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260603050219.91743-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chentao@kylinos.cn \
--cc=damon@lists.linux.dev \
--cc=kunwu.chan@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox