Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Gutierrez Asier <gutierrez.asier@huawei-partners.com>
Cc: SeongJae Park <sj@kernel.org>,
	artem.kuzin@huawei.com, stepanov.anatoly@huawei.com,
	wangkefeng.wang@huawei.com, yanquanmin1@huawei.com,
	zuoze1@huawei.com, damon@lists.linux.dev,
	akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v3 0/4] mm/damon: Introduce a huge page collapsing mechanism using auto tuning
Date: Fri,  5 Jun 2026 17:24:45 -0700	[thread overview]
Message-ID: <20260606002445.88776-1-sj@kernel.org> (raw)
In-Reply-To: <9f9e2159-5a6b-496f-9633-fa06c0217948@huawei-partners.com>

On Fri, 5 Jun 2026 13:25:56 +0300 Gutierrez Asier <gutierrez.asier@huawei-partners.com> wrote:

> Hi SJ,
> 
> On 6/5/2026 4:34 AM, SeongJae Park wrote:
> > Hello Asier,
> > 
> > 
> > Thank you for revisioning this great patch!
> > 
> > On Thu, 4 Jun 2026 15:03:33 +0000 <gutierrez.asier@huawei-partners.com> wrote:
[...]
> >> Benchmarks
> >> ==========
[...]
> > Also, have you tried temporal quota tuner?
> 
> OK, I will give it try.

Sounds good!  These test results are great contributions for DAMON community.
Nonetheless I don't think those are blocker of this series.  You could run more
tests and share results even after this series is merged first if you want to.

[...]
> >> Patches Sequence
> >> ================
> >> Patch 1 -> Introduce DAMOS_QUOTA_HUGEPAGE and autotuning
> >> Patch 2 -> damon_modules_new_vaddr_ctx_target
> >> Patch 3 -> Module that demonstrates how to use DAMOS_QUOTA_HUGEPAGE
> >>            and the new VADDR ctx creation
> >> Patch 4 -> Documentation
> > 
> > As I commented to each patch, patch 1 looks good except a few trivial things.
> > Patch 2 seems unnecessary.  I hope patch 3 to be much simplified and wrote
> > again following the sample modules' pattern.  Patch 4 seems too much for a
> > sample module.
> Thanks for the feedback, I will work out the patches.

I have a trivial comment about the 32-bit overflow issue, but everythinng
except that look good to me.

I feel like we are going on the right direction and this series is getting
closer to land!


Thanks,
SJ

[...]


      reply	other threads:[~2026-06-06  0:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-04 15:03 [RFC PATCH v3 0/4] mm/damon: Introduce a huge page collapsing mechanism using auto tuning gutierrez.asier
2026-06-04 15:03 ` [RFC PATCH v3 1/4] mm/damon: Introduce DAMOS_QUOTA_HUGEPAGE " gutierrez.asier
2026-06-05  0:44   ` SeongJae Park
2026-06-05 11:00     ` Gutierrez Asier
2026-06-06  0:14       ` SeongJae Park
2026-06-04 15:03 ` [RFC PATCH v3 2/4] mm/damon: Generalize ctx_target creation for damon_ops_id and add vaddr support gutierrez.asier
2026-06-05  0:50   ` SeongJae Park
2026-06-05 11:13     ` Gutierrez Asier
2026-06-06  0:15       ` SeongJae Park
2026-06-04 15:03 ` [RFC PATCH v3 3/4] mm/damon: introduce DAMON_HUGEPAGE for hot region hugepage collapsing gutierrez.asier
2026-06-05  1:06   ` SeongJae Park
2026-06-05 13:47     ` Gutierrez Asier
2026-06-04 15:03 ` [RFC PATCH v3 4/4] Documentation/admin-guide/mm/damon: add DAMON-based Hugepage Management gutierrez.asier
2026-06-05  1:09   ` SeongJae Park
2026-06-05 10:28     ` Gutierrez Asier
2026-06-05  1:34 ` [RFC PATCH v3 0/4] mm/damon: Introduce a huge page collapsing mechanism using auto tuning SeongJae Park
2026-06-05 10:25   ` Gutierrez Asier
2026-06-06  0:24     ` SeongJae Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260606002445.88776-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=artem.kuzin@huawei.com \
    --cc=damon@lists.linux.dev \
    --cc=gutierrez.asier@huawei-partners.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=stepanov.anatoly@huawei.com \
    --cc=wangkefeng.wang@huawei.com \
    --cc=yanquanmin1@huawei.com \
    --cc=zuoze1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox