From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01004CD8CB2 for ; Wed, 10 Jun 2026 15:41:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FCBF6B009D; Wed, 10 Jun 2026 11:41:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D4406B009E; Wed, 10 Jun 2026 11:41:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E9876B009F; Wed, 10 Jun 2026 11:41:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3E87D6B009D for ; Wed, 10 Jun 2026 11:41:13 -0400 (EDT) Received: from smtpin03.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 04140140136 for ; Wed, 10 Jun 2026 15:41:12 +0000 (UTC) X-FDA: 84864416826.03.9D1D98F Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf15.hostedemail.com (Postfix) with ESMTP id 67984A0003 for ; Wed, 10 Jun 2026 15:41:11 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b="Cw/B8aoH"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of vbabka@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=vbabka@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1781106071; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Mexx5lD21ZUkTPtQWUL+ov3B4ZXu0cDITz5foBNYJFU=; b=IR5pUTxYDpFBNY8PjZEEm4AWeIgNoWvS8uxg699aYmIuXDfaKktdPIDlIX5X9GE1XgfOco +7rvm6dCD8J+nUsGaPWXgm4Ym8MCLuR+MeHqmurDmtcF0Zh8QU/dTvsWipLZ4n896Qvd+D jhiyL49qrmILfdtNBPuIEF4VPH5/yM0= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b="Cw/B8aoH"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of vbabka@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=vbabka@kernel.org ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1781106071; b=UtRsRmTNoOXPRaBkug0njepniFDDK15U2u7Lcaic/uwp8aU7VtytL3fpaYXAP1UGMSdORU 8bfEtv6Y02skBWGxm7tRUVmSlh2hgwzir5hucT1jFEIXNo/YhZEBy/HWRPZJeZ2aUIH4F5 W3o2vc/TTvUKMVp8lvP63kKn3zPHtJc= Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 0103F601E1; Wed, 10 Jun 2026 15:41:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B53D1F00898; Wed, 10 Jun 2026 15:41:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781106070; bh=Mexx5lD21ZUkTPtQWUL+ov3B4ZXu0cDITz5foBNYJFU=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=Cw/B8aoHhqstcutNmiUGTHn+ICFdYtdKlcju3TXdMB7hIcJcS2GsTTpsUB0+Z+Bbq 2xX82XGTZNZqF1sjDhTDvd7Hf08jgo9fr6ZSTnDaYwExWExnjwMP8siFAmPh8f5X4j JnPgag3rXpzNeI21Yz2pJSB3u7FnSV5u+DNjRxL0+julH1Rkh+pJZdHbwvbVqocYxd KtK9WQmHSaz+jGclY8IneafQwttMX3zcjPlP8HRbCFQpGKXDeUNVOnqVqike7o4dAp f0FJx5oAvUTUrwQRC9xqgXaDRI9VvQ4yNyBdAzOi3Co/SslxdWKv3zhzVh/IkNMS+t b6VSc2o64zSJA== From: "Vlastimil Babka (SUSE)" Date: Wed, 10 Jun 2026 17:40:09 +0200 Subject: [PATCH v2 07/16] mm/slab: replace struct partial_context with slab_alloc_context MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260610-slab_alloc_flags-v2-7-7190909db118@kernel.org> References: <20260610-slab_alloc_flags-v2-0-7190909db118@kernel.org> In-Reply-To: <20260610-slab_alloc_flags-v2-0-7190909db118@kernel.org> To: Harry Yoo Cc: Hao Li , Christoph Lameter , David Rientjes , Roman Gushchin , Suren Baghdasaryan , Alexei Starovoitov , Andrew Morton , Johannes Weiner , Michal Hocko , Shakeel Butt , Alexander Potapenko , Marco Elver , Dmitry Vyukov , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, "Vlastimil Babka (SUSE)" X-Mailer: b4 0.15.2 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 67984A0003 X-Stat-Signature: ines1hif5dp7d4671zpuap8xkh8kcec1 X-Rspam-User: X-HE-Tag: 1781106071-715116 X-HE-Meta: U2FsdGVkX1+L52wM4Hys5nr9UfTFTuL2Y+RTzzaFCWlTrKEX6SQm4A9zSbMSrZMxaBTfN2VoNIep+FaWpumokPR6BUgMlDshS+D3TR3TYCmM/CKD6pbdnuWgz2ebac6Eu5a3Agb/hfnQ8O8k6wFIVQsso1F45O65zsKeNWvaKlbTRSqCnF//Py1UBEqotdZeEr8LZp2IcGw2wz45k+3kSIFthmiPV/GVuhUZaiNebVRui6OYagQ34vRt+FTivqOj67zR+/FjRApDs45X9EAIUoG73jjpScbb3iYPahXuH1Z6tAIWD65orHQurxDczvEXen+lC5kgTX7dzx1JhHSDpY3kK+4VFDex+AiM1V7Bnm7KWUMfD8u0hD0A+kuWNrMYbm7KRRga9j+0uus9mvF1KoTlpj08YN/brwxrxtxq2pn2zcGdmGyBLM6oblBT2uhsK6W8MUnCe56VjozzqPFoen59dbr3awkoSaZmESI/rebrUaiiu5/YHOx/XwYg9D6t0GHm5iGIOKnmkEcTyYGZEftVpqkueuMfy060PAFX83s6FnZ0EPUD9bi0yrs+nNXApVSblkq4ublbwpwJXuuWwJ1ZjtYi40rFoZ6pCSie1ykLITkkklQFvMHovlGuFqTGV94DF8c0djh10DM5WKg26rCmLs3wAztb0rbRStSagw22rxUfWcrj3X6KreWJwwUGbTvohmdNRHJDuUot4KKPAuXN1MlxV/podnLcx2z9h7TOJk9ktaEyo2S4jbuWJatKyUgd11CEgfgAMJDaFkKzs2v8ffyWomIzY9b/ImKR4DGPxTkS9oZoZaNs0uycZK7yY34gtV3YJO9dM1g6o7u1lHQgGi+nJgzhBCYVScwE/+nbDGCBy5BeXUD2dlf/wcHRJXEM7jrWl5EFAZpDZnh0zzRIR9Nj+073gNapZwZO55bTUTPCELTKoUfojBkMj86q0MMZ3jpKHvRen5+LNP4 Qqxvg2yr w1IP3r9VWta5Z2DvtdXRoOWH36QM8EJmjITB8AClwEdTNP3vSxDlS4+T9aOIXRaFM7sR4nK0/M0MGjcM0qVli7WwG+75UHWUaHSlO6VUKnqdA5YnP/I+bYeyZZhP5Aodfq5VSeFF97PdiQR5h3Y2ZWGupPkUV3mGixeaPq/NGm9a1BNSO10HJzj1oUUdY4FVq5PGzB9hxLDLbYbPXp0rwx7howYp6gSAzSd5IMfkpwlA5pPl/HILfiHRA8Y5H7DJWRaVLPQ0lwjgMfL6s5hbP+/oevZVqT+aPSP/n Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Refactor get_from_partial_node(), get_from_any_partial(), get_from_partial() and ___slab_alloc(). Remove struct partial_context, which used to be more substantial but shrank as part of the sheaves conversion. Instead pass gfp_flags and pointer to the new slab_alloc_context, which together is a superset of partial_context. This means alloc_flags are now available and we can use them to determine if spinning is allowed, further reducing false positive "not allowed" in the slow path due to gfp flags lacking __GFP_RECLAIM. Signed-off-by: Vlastimil Babka (SUSE) --- mm/slub.c | 52 ++++++++++++++++++++++++---------------------------- 1 file changed, 24 insertions(+), 28 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index ef745b37d063..98b79e5e7679 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -220,12 +220,6 @@ struct slab_alloc_context { unsigned int alloc_flags; }; -/* Structure holding parameters for get_from_partial() call chain */ -struct partial_context { - gfp_t flags; - unsigned int orig_size; -}; - /* Structure holding parameters for get_partial_node_bulk() */ struct partial_bulk_context { gfp_t flags; @@ -3826,7 +3820,8 @@ static bool get_partial_node_bulk(struct kmem_cache *s, */ static void *get_from_partial_node(struct kmem_cache *s, struct kmem_cache_node *n, - struct partial_context *pc) + gfp_t gfp_flags, + struct slab_alloc_context *ac) { struct slab *slab, *slab2; unsigned long flags; @@ -3841,7 +3836,7 @@ static void *get_from_partial_node(struct kmem_cache *s, if (!n || !n->nr_partial) return NULL; - if (gfpflags_allow_spinning(pc->flags)) + if (alloc_flags_allow_spinning(ac->alloc_flags)) spin_lock_irqsave(&n->list_lock, flags); else if (!spin_trylock_irqsave(&n->list_lock, flags)) return NULL; @@ -3849,12 +3844,12 @@ static void *get_from_partial_node(struct kmem_cache *s, struct freelist_counters old, new; - if (!pfmemalloc_match(slab, pc->flags)) + if (!pfmemalloc_match(slab, gfp_flags)) continue; if (IS_ENABLED(CONFIG_SLUB_TINY) || kmem_cache_debug(s)) { object = alloc_single_from_partial(s, n, slab, - pc->orig_size); + ac->orig_size); if (object) break; continue; @@ -3888,15 +3883,16 @@ static void *get_from_partial_node(struct kmem_cache *s, /* * Get an object from somewhere. Search in increasing NUMA distances. */ -static void *get_from_any_partial(struct kmem_cache *s, struct partial_context *pc) +static void *get_from_any_partial(struct kmem_cache *s, gfp_t gfp_flags, + struct slab_alloc_context *ac) { #ifdef CONFIG_NUMA struct zonelist *zonelist; struct zoneref *z; struct zone *zone; - enum zone_type highest_zoneidx = gfp_zone(pc->flags); + enum zone_type highest_zoneidx = gfp_zone(gfp_flags); unsigned int cpuset_mems_cookie; - bool allow_spin = gfpflags_allow_spinning(pc->flags); + bool allow_spin = alloc_flags_allow_spinning(ac->alloc_flags); /* * The defrag ratio allows a configuration of the tradeoffs between @@ -3930,16 +3926,17 @@ static void *get_from_any_partial(struct kmem_cache *s, struct partial_context * if (allow_spin) cpuset_mems_cookie = read_mems_allowed_begin(); - zonelist = node_zonelist(mempolicy_slab_node(), pc->flags); + zonelist = node_zonelist(mempolicy_slab_node(), gfp_flags); for_each_zone_zonelist(zone, z, zonelist, highest_zoneidx) { struct kmem_cache_node *n; n = get_node(s, zone_to_nid(zone)); - if (n && cpuset_zone_allowed(zone, pc->flags) && + if (n && cpuset_zone_allowed(zone, gfp_flags) && n->nr_partial > s->min_partial) { - void *object = get_from_partial_node(s, n, pc); + void *object = get_from_partial_node(s, n, + gfp_flags, ac); if (object) { /* @@ -3961,8 +3958,8 @@ static void *get_from_any_partial(struct kmem_cache *s, struct partial_context * /* * Get an object from a partial slab */ -static void *get_from_partial(struct kmem_cache *s, int node, - struct partial_context *pc) +static void *get_from_partial(struct kmem_cache *s, int node, gfp_t flags, + struct slab_alloc_context *ac) { int searchnode = node; void *object; @@ -3970,11 +3967,11 @@ static void *get_from_partial(struct kmem_cache *s, int node, if (node == NUMA_NO_NODE) searchnode = numa_mem_id(); - object = get_from_partial_node(s, get_node(s, searchnode), pc); - if (object || (node != NUMA_NO_NODE && (pc->flags & __GFP_THISNODE))) + object = get_from_partial_node(s, get_node(s, searchnode), flags, ac); + if (object || (node != NUMA_NO_NODE && (flags & __GFP_THISNODE))) return object; - return get_from_any_partial(s, pc); + return get_from_any_partial(s, flags, ac); } static bool has_pcs_used(int cpu, struct kmem_cache *s) @@ -4454,16 +4451,16 @@ static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node, struct slab_alloc_context *ac) { bool allow_spin = alloc_flags_allow_spinning(ac->alloc_flags); + gfp_t trynode_flags; void *object; struct slab *slab; - struct partial_context pc; bool try_thisnode = true; stat(s, ALLOC_SLOWPATH); new_objects: - pc.flags = gfpflags; + trynode_flags = gfpflags; /* * When a preferred node is indicated but no __GFP_THISNODE * @@ -4479,17 +4476,16 @@ static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node, && try_thisnode)) { if (unlikely(!allow_spin)) /* Do not upgrade gfp to NOWAIT from more restrictive mode */ - pc.flags = gfpflags | __GFP_THISNODE; + trynode_flags = gfpflags | __GFP_THISNODE; else - pc.flags = GFP_NOWAIT | __GFP_THISNODE; + trynode_flags = GFP_NOWAIT | __GFP_THISNODE; } - pc.orig_size = ac->orig_size; - object = get_from_partial(s, node, &pc); + object = get_from_partial(s, node, trynode_flags, ac); if (object) goto success; - slab = new_slab(s, pc.flags, node); + slab = new_slab(s, trynode_flags, node); if (unlikely(!slab)) { if (node != NUMA_NO_NODE && !(gfpflags & __GFP_THISNODE) -- 2.54.0