From: SeongJae Park <sj@kernel.org>
To: Sailesh Nandanavanam <saileshnandanavanam@gmail.com>
Cc: SeongJae Park <sj@kernel.org>,
shuah@kernel.org, damon@lists.linux.dev, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm/damon: add KUnit test for walk_control_obsolete behavior
Date: Fri, 12 Jun 2026 08:05:23 -0700 [thread overview]
Message-ID: <20260612150524.95770-1-sj@kernel.org> (raw)
In-Reply-To: <20260612062337.2459-1-saileshnandanavanam@gmail.com>
Hello Sailesh,
Thank you for this patch!
From next time, please send a new version of a patch as a new thread, not as a
reply to the previous version.
For the subject, please use mm/damon/tests/core-kunit: as the prefix.
On Fri, 12 Jun 2026 11:53:37 +0530 Sailesh Nandanavanam <saileshnandanavanam@gmail.com> wrote:
> Add a KUnit test to verify that damos_walk() rejects
> new requests when walk_control_obsolete is set.
>
> Commit 33c3f6c2b48c ("mm/damon/core: fix damos_walk() vs
> kdamond_fn() exit race") introduced walk_control_obsolete
> to prevent a race condition where new requests could be
> registered during kdamond shutdown and never handled.
>
> This test simulates the shutdown condition by setting
> walk_control_obsolete and verifies that damos_walk()
> returns -ECANCELED immediately.
>
> This validates the invariant introduced by the fix and
> helps prevent regressions.
>
> Suggested-by: SeongJae Park <sj@kernel.org>
> Signed-off-by: Sailesh Nandanavanam <saileshnandanavanam@gmail.com>
Other than the subject prefix, all looks good.
Reviewed-by: SeongJae Park <sj@kernel.org>
I applied this patch to damon/next [1] tree after modifying the subject prefix
as I suggested, assuming you don't mind. If you do mind that change, please
let me know.
We are now quite close to next merge window. We (mm community) want
to focus on making mm.git more stabilized and therefore ready for the next
merge window, rather than adding more changes that are not really urgent. I
understand this patch is not really urgent. Hence, Andrew might not add this
patch until next -rc1 release. In the case, I will request adding this to
mm.git after next -rc1 release. So, no action from your side is needed for
now.
[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees
Thanks,
SJ
[...]
prev parent reply other threads:[~2026-06-12 15:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-24 10:02 [PATCH v2] selftests/damon: add regression test for damos_walk() vs kdamond exit race Sailesh Nandanavanam
2026-05-24 18:37 ` SeongJae Park
2026-06-05 7:14 ` Sailesh Nandanavanam
2026-06-05 9:55 ` Sailesh Nandanavanam
2026-06-06 0:36 ` SeongJae Park
2026-06-11 20:20 ` Sailesh Nandanavanam
2026-06-11 20:36 ` Sailesh Nandanavanam
2026-06-12 0:11 ` SeongJae Park
2026-06-12 6:23 ` [PATCH v3] mm/damon: add KUnit test for walk_control_obsolete behavior Sailesh Nandanavanam
2026-06-12 15:05 ` SeongJae Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260612150524.95770-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=saileshnandanavanam@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox