Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	damon@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [RFC PATCH v1.3 04/18] mm/damon/core: handle unreset nr_accesses in damon_nr_accesses_mvsum()
Date: Mon, 22 Jun 2026 07:21:24 -0700	[thread overview]
Message-ID: <20260622142139.30269-5-sj@kernel.org> (raw)
In-Reply-To: <20260622142139.30269-1-sj@kernel.org>

damon_set_attrs() works like reverting aggregations that were made so
far for this aggregation window.  If this is the end of the aggregation,
however, kdamond_fn() will do the operations at the end of the
aggregation interval, using cached timestamps.  For such operations that
rely on damon_region->nr_accesses, damon_update_monitoring_results()
doesn't reset the nr_accesses if it is called at the end of the
aggregation window.

damon_nr_accesses_mvsum() works with fresh timestamps, though.  The
nr_accesses that are not reset in this case can make the logic to
unnecessarily count nr_accesses, resulting in returning
higher-than-expected pseudo moving sum nr_accesses.  No code is using
damon_nr_accesses_mvsum() yet, so this is not causing a real problem.
Following commits will add usage of the function, though.  For safe
usages, calculate the pseudo moving sum without nr_accesses if the
remaining window is full.

Signed-off-by: SeongJae Park <sj@kernel.org>
---
 mm/damon/core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index 191533685cf2f..9d501ad34f44c 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -268,6 +268,9 @@ unsigned int damon_nr_accesses_mvsum(struct damon_region *r,
 			ctx->passed_sample_intervals;
 	left_window_bp = mult_frac(left_window, 10000, window_len);
 
+	if (left_window_bp == 10000)
+		return r->last_nr_accesses;
+
 	return damon_mvsum(r->nr_accesses, r->last_nr_accesses,
 			left_window_bp);
 }
-- 
2.47.3


  parent reply	other threads:[~2026-06-22 14:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-22 14:21 [RFC PATCH v1.3 00/18] mm/damon: optimize out nr_accesses_bp SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 01/18] mm/damon: introduce damon_nr_accesses_mvsum() SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 02/18] mm/damon/tests/core-kunit: test damon_mvsum() SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 03/18] mm/damon/core: always update ->last_nr_accesses for intervals change SeongJae Park
2026-06-22 14:21 ` SeongJae Park [this message]
2026-06-22 14:21 ` [RFC PATCH v1.3 05/18] mm/damon/core: use damon_nr_accesses_mvsum() in __damos_valid_target() SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 06/18] mm/damon/core: use damon_nr_accesses_mvsum() for damos region tracing SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 07/18] mm/damon/sysfs-schemes: use damon_nr_accesses_mvsum() for damo regions SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 08/18] mm/damon/core: remove damon_warn_fix_nr_accesses_corruption() SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 09/18] mm/damon/core: remove damon_verify_reset_aggregated() SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 10/18] mm/damon/core: remove damon_verify_merge_regions_of() SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 11/18] mm/damon/tests/core-kunit: remove nr_accesses_bp setup and tests SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 12/18] selftests/damon/drgn_dump_damon_status: do not dump nr_accesses_bp SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 13/18] mm/damon/core: remove nr_accesses_bp setups and updates SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 14/18] mm/damon/core: remove attrs param from damon_update_region_access_rate() SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 15/18] mm/damonn/paddr: remove attrs param from __damon_pa_check_access() SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 16/18] mm/damon/vaddr: remove attrs param from __damon_va_check_access() SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 17/18] mm/damon/core: remove damon_moving_sum() and its unit test SeongJae Park
2026-06-22 14:21 ` [RFC PATCH v1.3 18/18] mm/damon: remove damon_region->nr_accesses_bp SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260622142139.30269-5-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox