From: Salvatore Dipietro <dipiets@amazon.it>
To: <ritesh.list@gmail.com>, <willy@infradead.org>
Cc: <dipiets@amazon.it>, <abuehaze@amazon.com>,
<akpm@linux-foundation.org>, <alisaidi@amazon.com>,
<blakgeof@amazon.com>, <brauner@kernel.org>,
<dipietro.salvatore@gmail.com>, <djwong@kernel.org>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mm@kvack.org>, <linux-xfs@vger.kernel.org>,
<stable@vger.kernel.org>, <vbabka@suse.com>
Subject: Re: [PATCH 1/1] iomap: avoid compaction for costly folio order allocation
Date: Wed, 24 Jun 2026 08:06:36 +0000 [thread overview]
Message-ID: <20260624080639.17100-1-dipiets@amazon.it> (raw)
In-Reply-To: <20260527162412.19922-1-dipiets@amazon.it>
Hi Ritesh, Matthew,
I wanted to kindly follow up on my summary from May 27th regarding the best path
forward for this patch.
To recap, we benchmarked all proposed variations and shared the results:
| Patch | Change Location | Avg TPS | % vs Baseline |
|--------------------------------|------------------------|------------|:-------------:|
| Baseline (no patch) | — | 101,979.75 | — |
| v1 (original, iomap caller) | fs/iomap/buffered-io.c | 141,194.20 | +38.45% |
| Ritesh's suggestion | mm/filemap.c | 139,200.61 | +36.50% |
| Matthew's suggestion | mm/filemap.c | 143,863.82 | +41.07% |
| kcompactd background | mm/page_alloc.c | 134,278.47 | +31.67% |
I'd really appreciate any guidance on which direction would be acceptable for a v3 —
whether that's the page allocator approach (kcompactd background), one of the filemap.c
fixes, or something else entirely.
I'm happy to test any additional variations or direction to move this forward
--
Salvatore
AMAZON DEVELOPMENT CENTER ITALY SRL, viale Monte Grappa 3/5, 20124 Milano, Italia, Registro delle Imprese di Milano Monza Brianza Lodi REA n. 2504859, Capitale Sociale: 10.000 EUR i.v., Cod. Fisc. e P.IVA 10100050961, Societa con Socio Unico
next prev parent reply other threads:[~2026-06-24 8:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260403193535.9970-1-dipiets@amazon.it>
[not found] ` <20260403193535.9970-2-dipiets@amazon.it>
2026-04-04 1:13 ` [PATCH 1/1] iomap: avoid compaction for costly folio order allocation Ritesh Harjani
2026-04-04 4:15 ` Matthew Wilcox
2026-04-04 16:47 ` Ritesh Harjani
2026-04-04 20:46 ` Matthew Wilcox
2026-04-16 15:14 ` Ritesh Harjani
2026-04-20 16:33 ` Salvatore Dipietro
2026-04-20 18:44 ` Matthew Wilcox
2026-04-21 1:16 ` Ritesh Harjani
2026-04-28 15:02 ` Salvatore Dipietro
2026-05-03 5:52 ` Ritesh Harjani
2026-05-03 11:55 ` Matthew Wilcox
2026-05-06 12:33 ` Salvatore Dipietro
2026-05-27 16:24 ` Salvatore Dipietro
2026-05-31 23:29 ` Karim Manaouil
2026-06-05 10:58 ` Salvatore Dipietro
2026-06-24 8:06 ` Salvatore Dipietro [this message]
2026-06-24 12:21 ` Ritesh Harjani
2026-06-24 13:34 ` Christoph Hellwig
[not found] ` <adLlrSZ5oRAa_Hfd@dread>
2026-04-21 9:02 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260624080639.17100-1-dipiets@amazon.it \
--to=dipiets@amazon.it \
--cc=abuehaze@amazon.com \
--cc=akpm@linux-foundation.org \
--cc=alisaidi@amazon.com \
--cc=blakgeof@amazon.com \
--cc=brauner@kernel.org \
--cc=dipietro.salvatore@gmail.com \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ritesh.list@gmail.com \
--cc=stable@vger.kernel.org \
--cc=vbabka@suse.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox