Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Yousef Alhouseen <alhouseenyousef@gmail.com>
Cc: SeongJae Park <sj@kernel.org>,
	willy@infradead.org, jack@suse.cz, shikemeng@huaweicloud.com,
	linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/writeback: parse help before importing drgn
Date: Wed, 24 Jun 2026 17:27:52 -0700	[thread overview]
Message-ID: <20260625002752.96325-1-sj@kernel.org> (raw)
In-Reply-To: <20260624123514.7822-1-alhouseenyousef@gmail.com>

On Wed, 24 Jun 2026 14:35:14 +0200 Yousef Alhouseen <alhouseenyousef@gmail.com> wrote:

> wb_monitor.py imports drgn before argparse can handle "-h". That makes
> help fail on systems where drgn is not installed, even though the script
> does not need drgn to print usage text.

But...  How do you execute the drgn script on systems not having drgn?  I tried
to mimic the situation and reproduce the issue you are saying about, but what I
get is like below:

    $ sudo mv /usr/bin/drgn /usr/bin/drgn.bak
    $ drgn tools/writeback/wb_monitor.py
    -bash: /usr/bin/drgn: No such file or directory
    $ python tools/writeback/wb_monitor.py
    Traceback (most recent call last):
      File "/home/lkhack/linux/tools/writeback/wb_monitor.py", line 44, in <module>
        bdi_list                = prog['bdi_list']
                                  ^^^^
    NameError: name 'prog' is not defined


Thanks,
SJ

[...]


      reply	other threads:[~2026-06-25  0:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-24 12:35 [PATCH] tools/writeback: parse help before importing drgn Yousef Alhouseen
2026-06-25  0:27 ` SeongJae Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260625002752.96325-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=alhouseenyousef@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shikemeng@huaweicloud.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox