From: Andrew Morton <akpm@linux-foundation.org>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Andreas Larsson <andreas@gaisler.com>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Jann Horn <jannh@google.com>,
Peter Zijlstra <peterz@infradead.org>,
"Oscar Salvador (SUSE)" <osalvador@kernel.org>,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v2 2/3] mm: drop pte_clear_not_present_full()
Date: Mon, 29 Jun 2026 14:08:55 -0700 [thread overview]
Message-ID: <20260629140855.584366abb95888a2ecbf4a8b@linux-foundation.org> (raw)
In-Reply-To: <fd1b4199-ebbc-420b-afe4-3bea4b9149fc@kernel.org>
On Mon, 29 Jun 2026 19:43:53 +0200 "David Hildenbrand (Arm)" <david@kernel.org> wrote:
> > So... what's happening here?
>
> "nr_pages" are not modified in the function, so the compile does not complain.
> See below.
>
>
> A private build bot barked at me after v1 for
>
> arm-linux-gnueabi-gcc
> openrisc-allnoconfig
> um-allmodconfig
>
> For example:
>
> https://lore.kernel.org/all/202606121420.Wke8Ipgx-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> In file included from include/linux/kasan.h:38,
> from include/linux/slab.h:264,
> from lib/test_bitops.c:12:
> include/linux/pgtable.h: In function 'clear_not_present_full_ptes':
> >> include/linux/pgtable.h:974:31: error: parameter 'addr' set but not used
> [-Werror=unused-but-set-parameter=]
> 974 | unsigned long addr, pte_t *ptep, unsigned int nr, int
> full)
> | ~~~~~~~~~~~~~~^~~~
> cc1: all warnings being treated as errors
>
>
> The problem is that addr is updated (written) in the function but never read.
Oh, OK, thanks. I altered the changelog to read
"To prevent the compiler complaining on some configs about "set but not
used" addr parameter, silence that here."
next prev parent reply other threads:[~2026-06-29 21:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 13:49 [PATCH v2 0/3] mm: cleanup clear_not_present_full_ptes() David Hildenbrand (Arm)
2026-06-29 13:49 ` [PATCH v2 1/3] sparc/mm: drop custom pte_clear_not_present_full() David Hildenbrand (Arm)
2026-06-30 12:03 ` Lance Yang
2026-06-29 13:49 ` [PATCH v2 2/3] mm: drop pte_clear_not_present_full() David Hildenbrand (Arm)
2026-06-29 17:22 ` Andrew Morton
2026-06-29 17:43 ` David Hildenbrand (Arm)
2026-06-29 21:08 ` Andrew Morton [this message]
2026-06-30 12:38 ` Lance Yang
2026-06-29 13:49 ` [PATCH v2 3/3] mm: cleanup clear_not_present_full_ptes() and rename to clear_non_present_ptes() David Hildenbrand (Arm)
2026-06-30 13:05 ` Lance Yang
2026-06-30 13:47 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260629140855.584366abb95888a2ecbf4a8b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andreas@gaisler.com \
--cc=davem@davemloft.net \
--cc=david@kernel.org \
--cc=jannh@google.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=osalvador@kernel.org \
--cc=peterz@infradead.org \
--cc=rppt@kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox