Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yichong Chen <chenyichong@uniontech.com>
To: akpm@linux-foundation.org
Cc: vishal.moola@gmail.com, ye.liu@linux.dev, zhen.ni@easystack.cn,
	ziy@nvidia.com, chenyichong@uniontech.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/mm/page_owner_sort: report get_comm failures at source
Date: Tue, 30 Jun 2026 13:50:23 +0800	[thread overview]
Message-ID: <20260630055023.197943-1-chenyichong@uniontech.com> (raw)
In-Reply-To: <20260629203326.fbd5714e7ec8cbf0a22e7148@linux-foundation.org>

Hi Andrew,

Thanks for pointing this out.

I think keeping the parse-failure message under debug_on is acceptable here.
The failure still propagates through the existing NULL return path, and the
malformed-record dump is diagnostic output which matches the current debug
behavior.

If you prefer reporting this in normal mode as well, I think the minimal
change would be to drop the if (debug_on) guard before the existing error
message. Otherwise, I would prefer to keep the patch as-is.

Thanks,
Yichong


      reply	other threads:[~2026-06-30  5:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29  1:43 [PATCH v5 0/3] tools/mm/page_owner_sort: fix filtering and cleanup issues Yichong Chen
2026-06-29  1:43 ` [PATCH v5 1/3] tools/mm/page_owner_sort: return explicit filter results Yichong Chen
2026-06-29  1:43 ` [PATCH v5 2/3] tools/mm/page_owner_sort: free per-record allocations Yichong Chen
2026-06-29  1:43 ` [PATCH v5 3/3] tools/mm/page_owner_sort: bound pattern output copies Yichong Chen
2026-06-29  4:41 ` [PATCH v5 0/3] tools/mm/page_owner_sort: fix filtering and cleanup issues Andrew Morton
2026-06-29  6:25 ` [PATCH] tools/mm/page_owner_sort: report get_comm failures at source Yichong Chen
2026-06-30  3:33   ` Andrew Morton
2026-06-30  5:50     ` Yichong Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260630055023.197943-1-chenyichong@uniontech.com \
    --to=chenyichong@uniontech.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=vishal.moola@gmail.com \
    --cc=ye.liu@linux.dev \
    --cc=zhen.ni@easystack.cn \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox