From: Francesco Dolcini <francesco@dolcini.it>
To: "Mike Rapoport (Microsoft)" <rppt@kernel.org>,
Jeff Chen <jeff.chen_1@nxp.com>
Cc: Johannes Berg <johannes.berg@intel.com>,
Brian Norris <briannorris@chromium.org>,
Francesco Dolcini <francesco@dolcini.it>,
Jakub Kicinski <kuba@kernel.org>,
b43-dev@lists.infradead.org, libertas-dev@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 3/4] mwifiex: debugfs: use kzalloc() to allocate formatting buffers
Date: Wed, 1 Jul 2026 18:24:05 +0200 [thread overview]
Message-ID: <20260701162405.GA38581@francesco-nb> (raw)
In-Reply-To: <20260701-b4-drivers-wireless-v1-3-60264cdf2efe@kernel.org>
+Jeff
Jeff: this is relevant also for nxpwifi.
On Wed, Jul 01, 2026 at 04:59:12PM +0300, Mike Rapoport (Microsoft) wrote:
> mwifiex debugfs functions allocate buffers for formatting debug output
> text using get_zeroed_page().
>
> These buffers can be allocated with kmalloc() as there's nothing special
> about them to go directly to the page allocator.
>
> kmalloc() provides a better API that does not require ugly casts and
> kfree() does not need to know the size of the freed object.
>
> Performance difference between kmalloc() and __get_free_pages() is not
> measurable as both allocators take an object/page from a per-CPU list for
> fast path allocations.
>
> For the slow path the performance is anyway determined by the amount of
> reclaim involved rather than by what allocator is used.
>
> Replace use of get_zeroed_page() with kzalloc() and free_page() with
> kfree().
>
> Link: https://lore.kernel.org/all/635405e4-9423-4a25-a6e7-e03c8ea0bcbe@redhat.com
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
next prev parent reply other threads:[~2026-07-01 16:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 13:59 [PATCH 0/4] drivers/net: replace __get_free_pages() with kmalloc() Mike Rapoport (Microsoft)
2026-07-01 13:59 ` [PATCH 1/4] b43, b43legacy: debugfs: use kzalloc() to allocate formatting buffers Mike Rapoport (Microsoft)
2026-07-01 13:59 ` [PATCH 2/4] libertas: " Mike Rapoport (Microsoft)
2026-07-01 13:59 ` [PATCH 3/4] mwifiex: " Mike Rapoport (Microsoft)
2026-07-01 16:24 ` Francesco Dolcini [this message]
2026-07-01 13:59 ` [PATCH 4/4] wlcore: allocate aggregation and firmware log buffers with kzalloc() Mike Rapoport (Microsoft)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260701162405.GA38581@francesco-nb \
--to=francesco@dolcini.it \
--cc=b43-dev@lists.infradead.org \
--cc=briannorris@chromium.org \
--cc=jeff.chen_1@nxp.com \
--cc=johannes.berg@intel.com \
--cc=kuba@kernel.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox