Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: wang wei <a929244872@163.com>
To: sj@kernel.org, shuah@kernel.org, damon@lists.linux.dev,
	linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: wang wei <a929244872@163.com>
Subject: [PATCH] selftests/damon: check correct path in ensure_file() not_exist case
Date: Mon,  6 Jul 2026 21:43:04 +0800	[thread overview]
Message-ID: <20260706134305.5224-1-a929244872@163.com> (raw)

In the ensure_file() function, the "not_exist" code path checks
whether $dir exists as a regular file.  However, the intent is to
verify that the target file ($file) does not exist, not the $dir.
Testing $dir makes the existence check effectively useless --
it tests the wrong path and thus never catches the case
where the file is unexpectedly present.

Replace $dir with $file so the not_exist verification targets the
correct path.

Signed-off-by: wang wei <a929244872@163.com>
---
 tools/testing/selftests/damon/sysfs.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/damon/sysfs.sh b/tools/testing/selftests/damon/sysfs.sh
index 78f4badb5..bf4684d36 100755
--- a/tools/testing/selftests/damon/sysfs.sh
+++ b/tools/testing/selftests/damon/sysfs.sh
@@ -67,7 +67,7 @@ ensure_file()
 			echo "$file permission: expected $permission but $perm"
 			exit 1
 		fi
-	elif [ "$to_ensure" = "not_exist" ] && [ -f "$dir" ]
+	elif [ "$to_ensure" = "not_exist" ] && [ -f "$file" ]
 	then
 		echo "$file is not expected but found"
 		exit 1
-- 
2.43.0



             reply	other threads:[~2026-07-06 13:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06 13:43 wang wei [this message]
2026-07-06 14:29 ` [PATCH] selftests/damon: check correct path in ensure_file() not_exist case SJ Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260706134305.5224-1-a929244872@163.com \
    --to=a929244872@163.com \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shuah@kernel.org \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox