From: Sang-Heon Jeon <ekffu200098@gmail.com>
To: rppt@kernel.org, Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>
Cc: linux-mm@kvack.org, Sang-Heon Jeon <ekffu200098@gmail.com>,
Ard Biesheuvel <ardb@kernel.org>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
linux-kernel@vger.kernel.org,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Rich Felker <dalias@libc.org>, Thomas Gleixner <tglx@kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: [PATCH v2 4/5] xtensa: remove unreachable memblock_reserve() return value checks
Date: Tue, 7 Jul 2026 01:37:52 +0900 [thread overview]
Message-ID: <20260706163753.193875-5-ekffu200098@gmail.com> (raw)
In-Reply-To: <20260706163753.193875-1-ekffu200098@gmail.com>
mem_reserve() wraps memblock_reserve(), and its callers check the return
value. xtensa never calls memblock_allow_resize(), so memblock_reserve()
either succeeds or panics, never returning an error.
Therefore the return value checks are unreachable, so remove them and make
mem_reserve() return void.
No functional change.
Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
arch/xtensa/kernel/setup.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/arch/xtensa/kernel/setup.c b/arch/xtensa/kernel/setup.c
index f72e280363be..c7367b81cc36 100644
--- a/arch/xtensa/kernel/setup.c
+++ b/arch/xtensa/kernel/setup.c
@@ -268,10 +268,10 @@ void __init init_arch(bp_tag_t *bp_start)
* Initialize system. Setup memory and reserve regions.
*/
-static inline int __init_memblock mem_reserve(unsigned long start,
- unsigned long end)
+static inline void __init_memblock mem_reserve(unsigned long start,
+ unsigned long end)
{
- return memblock_reserve(start, end - start);
+ memblock_reserve(start, end - start);
}
void __init setup_arch(char **cmdline_p)
@@ -290,11 +290,12 @@ void __init setup_arch(char **cmdline_p)
/* Reserve some memory regions */
#ifdef CONFIG_BLK_DEV_INITRD
- if (initrd_start < initrd_end &&
- !mem_reserve(__pa(initrd_start), __pa(initrd_end)))
+ if (initrd_start < initrd_end) {
+ mem_reserve(__pa(initrd_start), __pa(initrd_end));
initrd_below_start_ok = 1;
- else
+ } else {
initrd_start = 0;
+ }
#endif
mem_reserve(__pa(_stext), __pa(_end));
--
2.43.0
next prev parent reply other threads:[~2026-07-06 16:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 16:37 [PATCH v2 0/5] treewide: remove unreachable memblock_reserve() return value checks in early boot Sang-Heon Jeon
2026-07-06 16:37 ` [PATCH v2 1/5] x86/setup: remove unreachable memblock_reserve() return value check Sang-Heon Jeon
2026-07-06 16:37 ` [PATCH v2 2/5] sh: " Sang-Heon Jeon
2026-07-06 16:37 ` [PATCH v2 3/5] powerpc/fadump: remove unreachable memblock_reserve() return value checks Sang-Heon Jeon
2026-07-06 16:37 ` Sang-Heon Jeon [this message]
2026-07-06 16:37 ` [PATCH v2 5/5] Revert "tpm: do not ignore memblock_reserve return value" Sang-Heon Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260706163753.193875-5-ekffu200098@gmail.com \
--to=ekffu200098@gmail.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=chris@zankel.net \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=jcmvbkbc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maddy@linux.ibm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=rppt@kernel.org \
--cc=tglx@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox