From: Dev Jain <dev.jain@arm.com>
To: akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org,
muchun.song@linux.dev, osalvador@suse.de
Cc: Dev Jain <dev.jain@arm.com>,
riel@surriel.com, liam@infradead.org, vbabka@kernel.org,
harry@kernel.org, jannh@google.com, lance.yang@linux.dev,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
ryan.roberts@arm.com, anshuman.khandual@arm.com
Subject: [PATCH 5/5] mm/rmap: add anon folio unmap dispatcher function
Date: Tue, 7 Jul 2026 12:11:23 +0000 [thread overview]
Message-ID: <20260707121128.373192-6-dev.jain@arm.com> (raw)
In-Reply-To: <20260707121128.373192-1-dev.jain@arm.com>
Add ttu_anon_folio() as the common entry point for anonymous folio
unmapping. It dispatches to the lazyfree or swapbacked helper as
appropriate, and centralizes restoration of cleared PTEs on failure.
No functional change intended.
Signed-off-by: Dev Jain <dev.jain@arm.com>
---
mm/rmap.c | 59 +++++++++++++++++++++++++++++++++----------------------
1 file changed, 36 insertions(+), 23 deletions(-)
diff --git a/mm/rmap.c b/mm/rmap.c
index ade78df5be2bd..f021ecd51a4a2 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -2171,6 +2171,40 @@ static inline bool ttu_anon_swapbacked_folio(struct vm_area_struct *vma, struct
return true;
}
+static inline bool ttu_anon_folio(struct vm_area_struct *vma, struct folio *folio,
+ struct page *subpage, unsigned long address, pte_t *ptep,
+ pte_t pteval, unsigned long nr_pages)
+{
+ struct mm_struct *mm = vma->vm_mm;
+ bool ret;
+
+ /*
+ * Store the swap location in the pte.
+ * See handle_pte_fault() ...
+ */
+ if (unlikely(folio_test_swapbacked(folio) !=
+ folio_test_swapcache(folio))) {
+ WARN_ON_ONCE(1);
+ return false;
+ }
+
+ /* MADV_FREE page check */
+ if (!folio_test_swapbacked(folio)) {
+ ret = ttu_anon_lazyfree_folio(vma, folio);
+ if (ret)
+ add_mm_counter(mm, MM_ANONPAGES, -nr_pages);
+ } else {
+ /* nr_pages > 1 not supported yet */
+ ret = ttu_anon_swapbacked_folio(vma, folio, subpage, address,
+ ptep, pteval);
+ }
+
+ if (!ret)
+ set_ptes(mm, address, ptep, pteval, nr_pages);
+
+ return ret;
+}
+
/*
* @arg: enum ttu_flags will be passed to this argument
*/
@@ -2351,31 +2385,10 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma,
*/
dec_mm_counter(mm, mm_counter(folio));
} else if (folio_test_anon(folio)) {
- /*
- * Store the swap location in the pte.
- * See handle_pte_fault() ...
- */
- if (unlikely(folio_test_swapbacked(folio) !=
- folio_test_swapcache(folio))) {
- WARN_ON_ONCE(1);
+ if (!ttu_anon_folio(vma, folio, subpage, address,
+ pvmw.pte, pteval, nr_pages))
goto walk_abort;
- }
- /* MADV_FREE page check */
- if (!folio_test_swapbacked(folio)) {
- if (!ttu_anon_lazyfree_folio(vma, folio)) {
- set_ptes(mm, address, pvmw.pte, pteval, nr_pages);
- goto walk_abort;
- }
- add_mm_counter(mm, MM_ANONPAGES, -nr_pages);
- goto finish_unmap;
- }
-
- if (!ttu_anon_swapbacked_folio(vma, folio, subpage, address,
- pvmw.pte, pteval)) {
- set_pte_at(mm, address, pvmw.pte, pteval);
- goto walk_abort;
- }
goto finish_unmap;
} else {
/*
--
2.43.0
next prev parent reply other threads:[~2026-07-07 12:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 12:11 [PATCH 0/5] mm/rmap: Refactor try_to_unmap_one Dev Jain
2026-07-07 12:11 ` [PATCH 1/5] mm/rmap: convert page -> folio for hwpoison checks Dev Jain
2026-07-07 14:06 ` David Hildenbrand (Arm)
2026-07-07 12:11 ` [PATCH 2/5] mm/rmap: Add try_to_unmap_hugetlb_one Dev Jain
2026-07-07 14:15 ` David Hildenbrand (Arm)
2026-07-07 12:11 ` [PATCH 3/5] mm/rmap: refactor some code around lazyfree folio unmapping Dev Jain
2026-07-07 14:18 ` David Hildenbrand (Arm)
2026-07-07 12:11 ` [PATCH 4/5] mm/rmap: refactor anon swapbacked folio unmap in try_to_unmap_one Dev Jain
2026-07-07 14:26 ` David Hildenbrand (Arm)
2026-07-07 12:11 ` Dev Jain [this message]
2026-07-07 14:28 ` [PATCH 5/5] mm/rmap: add anon folio unmap dispatcher function David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260707121128.373192-6-dev.jain@arm.com \
--to=dev.jain@arm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=david@kernel.org \
--cc=harry@kernel.org \
--cc=jannh@google.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=riel@surriel.com \
--cc=ryan.roberts@arm.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox