From: Andrew Morton <akpm@linux-foundation.org>
To: Barry Song <baohua@kernel.org>
Cc: "David Hildenbrand (Arm)" <david@kernel.org>,
linux-mm@kvack.org, baoquan.he@linux.dev, chrisl@kernel.org,
jp.kobryn@linux.dev, kasong@tencent.com, liam@infradead.org,
linux-kernel@vger.kernel.org, ljs@kernel.org, mhocko@suse.com,
nphamcs@gmail.com, rppt@kernel.org, shakeel.butt@linux.dev,
shikemeng@huaweicloud.com, surenb@google.com,
usama.arif@linux.dev, vbabka@kernel.org, youngjun.park@lge.com
Subject: Re: [PATCH v3 2/4] mm: drop stale folio_ref_count()==1 check in do_swap_page reuse logic
Date: Tue, 7 Jul 2026 13:18:10 -0700 [thread overview]
Message-ID: <20260707131810.96a4c1c56e00264b311133d8@linux-foundation.org> (raw)
In-Reply-To: <CAGsJ_4zGBK7ndTyFnzdzw0tuwaQwbCChVBdkC4E1YBE0NwVHcg@mail.gmail.com>
On Tue, 7 Jul 2026 19:08:13 +0800 Barry Song <baohua@kernel.org> wrote:
> > Sashiko points out two minor things (one flagged as medium, lol, sure sure).
> >
> > Here, you can clarify that folio_ref_count()==1 is true for freshly allocated
> > pages (due to the KSM check) in which case exclusive=true already.
>
> Hi Andrew,
>
> I saw that you've queued this in mm-new. Thanks very much for that!
>
> Would you mind adding the following sentences to the end of the changelog?
>
> The ksm_might_need_to_copy() check may allocate a fresh folio with
> folio_ref_count() == 1. Along that path, exclusive has already been
> set to true, so the folio can still be reused correctly.
Done, thanks.
next prev parent reply other threads:[~2026-07-07 20:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260701235955.36126-1-baohua@kernel.org>
[not found] ` <20260701235955.36126-3-baohua@kernel.org>
[not found] ` <3a185a5d-2f2c-4e9d-9cd9-8bdb236dfc5c@kernel.org>
2026-07-06 8:14 ` [PATCH v3 2/4] mm: drop stale folio_ref_count()==1 check in do_swap_page reuse logic Barry Song
2026-07-07 11:08 ` Barry Song
2026-07-07 20:18 ` Andrew Morton [this message]
[not found] ` <20260701235955.36126-2-baohua@kernel.org>
2026-07-07 12:55 ` [PATCH v3 1/4] mm: avoid unnecessary lru drain for wp_can_reuse_anon_folio() Baoquan He
[not found] ` <a9829fdd-75b3-4035-935a-f3a74fdc29bc@kernel.org>
2026-07-06 8:18 ` Barry Song
2026-07-06 9:12 ` Baoquan He
2026-07-06 9:17 ` Barry Song
2026-07-07 15:26 ` Kairui Song
2026-07-07 15:58 ` David Hildenbrand (Arm)
2026-07-08 14:57 ` Barry Song (Xiaomi)
2026-07-07 15:21 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260707131810.96a4c1c56e00264b311133d8@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baoquan.he@linux.dev \
--cc=chrisl@kernel.org \
--cc=david@kernel.org \
--cc=jp.kobryn@linux.dev \
--cc=kasong@tencent.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=nphamcs@gmail.com \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=shikemeng@huaweicloud.com \
--cc=surenb@google.com \
--cc=usama.arif@linux.dev \
--cc=vbabka@kernel.org \
--cc=youngjun.park@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox