From: SJ Park <sj@kernel.org>
To: Muchun Song <songmuchun@bytedance.com>
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
Shuah Khan <shuah@kernel.org>, Lorenzo Stoakes <ljs@kernel.org>,
"Liam R . Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, muchun.song@linux.dev
Subject: Re: [PATCH] selftests/mm: remove obsolete hugetlb vmemmap test
Date: Fri, 10 Jul 2026 17:32:14 -0700 [thread overview]
Message-ID: <20260711003215.32222-1-sj@kernel.org> (raw)
In-Reply-To: <20260710092427.3459121-1-songmuchun@bytedance.com>
On Fri, 10 Jul 2026 17:24:27 +0800 Muchun Song <songmuchun@bytedance.com> wrote:
> The hugetlb vmemmap selftest was added to check the old HVO
> layout where tail vmemmap pages reused the head page. That
> assumption no longer matches the current HVO mapping layout.
>
> HVO now keeps a private backing page for the head vmemmap page
> and remaps redundant tail vmemmap pages to a shared read-only
> backing page. The old page flag check is therefore testing an
> obsolete implementation detail rather than the current ABI or
> behavior.
>
> Remove the stale test and its build, run, and ignore entries.
Nice!
>
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
Reviewed-by: SJ Park <sj@kernel.org>
> ---
> tools/testing/selftests/mm/.gitignore | 2 -
> tools/testing/selftests/mm/Makefile | 1 -
> tools/testing/selftests/mm/hugetlb-vmemmap.c | 132 -------------------
> tools/testing/selftests/mm/run_vmtests.sh | 1 -
> 4 files changed, 136 deletions(-)
> delete mode 100644 tools/testing/selftests/mm/hugetlb-vmemmap.c
>
> diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore
> index 9ccd9e1447e6..227476d8ff1f 100644
> --- a/tools/testing/selftests/mm/.gitignore
> +++ b/tools/testing/selftests/mm/.gitignore
> @@ -3,11 +3,9 @@ cow
> hugepage-mmap
> hugepage-mremap
> hugepage-shm
> -hugepage-vmemmap
> hugetlb-mmap
> hugetlb-mremap
> hugetlb-shm
> -hugetlb-vmemmap
> hugetlb-madvise
> hugetlb-read-hwpoison
> hugetlb-soft-offline
I remember Linus argued [1] we shouldn't remove names from giignore. I don't
really care, so feel free to add my R-b: tag. I just wanted to call out,
though.
[1] https://lore.kernel.org/all/CAHk-=whVY4mq1Fd=Vhwy0dK8fR5cOLkiy1OZMG4QyEMaGEd9ZQ@mail.gmail.com/
Thanks,
SJ
[...]
prev parent reply other threads:[~2026-07-11 0:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 9:24 [PATCH] selftests/mm: remove obsolete hugetlb vmemmap test Muchun Song
2026-07-10 11:01 ` Lorenzo Stoakes
2026-07-10 11:12 ` David Hildenbrand (Arm)
2026-07-11 0:32 ` SJ Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260711003215.32222-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=songmuchun@bytedance.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox