Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: SJ Park <sj@kernel.org>
To: Enze Li <lienze@kylinos.cn>
Cc: SJ Park <sj@kernel.org>,
	akpm@linux-foundation.org, damon@lists.linux.dev,
	linux-mm@kvack.org, enze.li@gmx.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/damon/ops-common: remove redundant local variable in damon_migrate_folio_list()
Date: Fri, 17 Jul 2026 18:06:52 -0700	[thread overview]
Message-ID: <20260718010652.92773-1-sj@kernel.org> (raw)
In-Reply-To: <20260718002125.637104-1-lienze@kylinos.cn>

Hello Enze,

get_maintainer.pl suggests to Cc linux-kernel@vger.kernel.org too.  Adding it
to Cc list.

On Sat, 18 Jul 2026 08:21:25 +0800 Enze Li <lienze@kylinos.cn> wrote:

> In damon_migrate_folio_list(), we're redeclaring folio inside the first
> while loop, but it just shadows the outer one.  Since the second loop
> uses the outer folio anyway, the inner declaration is pointless.
> 
> Remove it to consistently reuse the same variable throughout the
> function and improve readability.

Nice catch!

> 
> Signed-off-by: Enze Li <lienze@kylinos.cn>

Reviewed-by: SJ Park <sj@kernel.org>

This patch is applied to damon/next [1] tree.  If this patch is not added to
mm.git in short term (~1 week?), I will ask mm.git maintainer (Andrew Morton)
to pick this.  So, no action from your side is needed for now.  If it seems I
also forgot doing that or you cannot wait for my action, please feel free to
directly ask that to Andrew.

[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees


Thanks,
SJ

[...]


      reply	other threads:[~2026-07-18  1:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-18  0:21 [PATCH] mm/damon/ops-common: remove redundant local variable in damon_migrate_folio_list() Enze Li
2026-07-18  1:06 ` SJ Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260718010652.92773-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=enze.li@gmx.com \
    --cc=lienze@kylinos.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox