From: Andrew Morton <akpm@linux-foundation.org>
To: Arvind Yadav <arvind.yadav@intel.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
david@kernel.org, matthew.brost@intel.com,
joshua.hahnjy@gmail.com, ziy@nvidia.com, rakie.kim@sk.com,
byungchul@sk.com, gourry@gourry.net,
ying.huang@linux.alibaba.com, apopple@nvidia.com,
Balbir Singh <balbirs@nvidia.com>
Subject: Re: [PATCH v2] mm/migrate_device: Clear stale mapping after freeing swapcache
Date: Fri, 24 Jul 2026 21:43:07 -0700 [thread overview]
Message-ID: <20260724214307.a50ed52cf78fdc73bc42f9bf@linux-foundation.org> (raw)
In-Reply-To: <20260724082702.2531024-1-arvind.yadav@intel.com>
On Fri, 24 Jul 2026 13:57:02 +0530 Arvind Yadav <arvind.yadav@intel.com> wrote:
> __migrate_device_pages() reads the folio mapping before calling
> folio_free_swap(). When folio_free_swap() succeeds, the folio is removed
> from the swap cache, but the saved mapping still points to swap_space.
>
> Passing the stale mapping to folio_migrate_mapping() makes it take the
> mapped-folio path after the swapcache reference has been dropped. This can
> cause an invalid swap_space lock access followed by a folio reference
> count BUG.
>
> Refresh the saved mapping after folio_free_swap() so the current folio
> state is used during migration.
>
Thanks. AI review might have found an issue with this. And one
possible pre-existing issue in the code which Alistair and Balbir
worked on.
https://sashiko.dev/#/patchset/20260724082702.2531024-1-arvind.yadav@intel.com
next prev parent reply other threads:[~2026-07-25 4:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 8:27 [PATCH v2] mm/migrate_device: Clear stale mapping after freeing swapcache Arvind Yadav
2026-07-24 14:00 ` Zi Yan
2026-07-25 4:43 ` Andrew Morton [this message]
2026-07-25 19:36 ` David Hildenbrand (Arm)
2026-07-25 21:05 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260724214307.a50ed52cf78fdc73bc42f9bf@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=arvind.yadav@intel.com \
--cc=balbirs@nvidia.com \
--cc=byungchul@sk.com \
--cc=david@kernel.org \
--cc=gourry@gourry.net \
--cc=joshua.hahnjy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.brost@intel.com \
--cc=rakie.kim@sk.com \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox