From: SJ Park <sj@kernel.org>
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [RFC PATCH v2.1 10/17] mm/damon/sysfs: implement preps/nr_preps file
Date: Mon, 27 Jul 2026 07:38:19 -0700 [thread overview]
Message-ID: <20260727143829.86236-11-sj@kernel.org> (raw)
In-Reply-To: <20260727143829.86236-1-sj@kernel.org>
Implement nr_preps file under the preps directory. It will be evolved
to be used for generating sub directories that will represent each probe
preparation action.
Signed-off-by: SJ Park <sj@kernel.org>
---
mm/damon/sysfs.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 52 insertions(+), 1 deletion(-)
diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
index e33070d2cbcc6..6d3ed80fb2eb1 100644
--- a/mm/damon/sysfs.c
+++ b/mm/damon/sysfs.c
@@ -756,6 +756,7 @@ static const struct kobj_type damon_sysfs_intervals_ktype = {
struct damon_sysfs_preps {
struct kobject kobj;
+ int nr;
};
static struct damon_sysfs_preps *damon_sysfs_preps_alloc(void)
@@ -763,12 +764,60 @@ static struct damon_sysfs_preps *damon_sysfs_preps_alloc(void)
return kzalloc_obj(struct damon_sysfs_preps);
}
+static void damon_sysfs_preps_rm_dirs(struct damon_sysfs_preps *preps)
+{
+ preps->nr = 0;
+}
+
+static int damon_sysfs_preps_add_dirs(struct damon_sysfs_preps *preps,
+ int nr_preps)
+{
+ preps->nr = nr_preps;
+ return 0;
+}
+
+static ssize_t nr_preps_show(struct kobject *kobj, struct kobj_attribute *attr,
+ char *buf)
+{
+ struct damon_sysfs_preps *preps = container_of(kobj,
+ struct damon_sysfs_preps, kobj);
+
+ return sysfs_emit(buf, "%d\n", preps->nr);
+}
+
+static ssize_t nr_preps_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf, size_t count)
+{
+ struct damon_sysfs_preps *preps;
+ int nr, err = kstrtoint(buf, 0, &nr);
+
+ if (err)
+ return err;
+ if (nr < 0)
+ return -EINVAL;
+
+ preps = container_of(kobj, struct damon_sysfs_preps, kobj);
+
+ if (!mutex_trylock(&damon_sysfs_lock))
+ return -EBUSY;
+ err = damon_sysfs_preps_add_dirs(preps, nr);
+ mutex_unlock(&damon_sysfs_lock);
+ if (err)
+ return err;
+
+ return count;
+}
+
static void damon_sysfs_preps_release(struct kobject *kobj)
{
kfree(container_of(kobj, struct damon_sysfs_preps, kobj));
}
+static struct kobj_attribute damon_sysfs_preps_nr_attr =
+ __ATTR_RW_MODE(nr_preps, 0600);
+
static struct attribute *damon_sysfs_preps_attrs[] = {
+ &damon_sysfs_preps_nr_attr.attr,
NULL,
};
ATTRIBUTE_GROUPS(damon_sysfs_preps);
@@ -1150,8 +1199,10 @@ static int damon_sysfs_probe_add_dirs(struct damon_sysfs_probe *probe)
static void damon_sysfs_probe_rm_dirs(struct damon_sysfs_probe *probe)
{
- if (probe->preps)
+ if (probe->preps) {
+ damon_sysfs_preps_rm_dirs(probe->preps);
kobject_put(&probe->preps->kobj);
+ }
if (probe->filters) {
damon_sysfs_filters_rm_dirs(probe->filters);
kobject_put(&probe->filters->kobj);
--
2.47.3
next prev parent reply other threads:[~2026-07-27 14:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 14:38 [RFC PATCH v2.1 00/17] mm/damon: introduce data access-as-a-data attribute SJ Park
2026-07-27 14:38 ` [RFC PATCH v2.1 01/17] mm/damon/core: introduce DAMON_FILTER_TYPE_PGIDLE_UNSET SJ Park
2026-07-27 14:38 ` [RFC PATCH v2.1 02/17] mm/damon/paddr: support PGIDLE_UNSET probe filter type SJ Park
2026-07-27 14:38 ` [RFC PATCH v2.1 03/17] mm/damon/sysfs: support pgidle_unset " SJ Park
2026-07-27 14:38 ` [RFC PATCH v2.1 04/17] Docs/mm/damon/design: document " SJ Park
2026-07-27 14:38 ` [RFC PATCH v2.1 05/17] mm/damon/core: introduce damon_prep struct SJ Park
2026-07-27 14:38 ` [RFC PATCH v2.1 06/17] mm/damon/core: commit preps SJ Park
2026-07-27 14:38 ` [RFC PATCH v2.1 07/17] mm/damon/core: introduce damon_operations->prep_probes() SJ Park
2026-07-27 14:38 ` [RFC PATCH v2.1 08/17] mm/damon/paddr: support damon_prep SJ Park
2026-07-27 14:38 ` [RFC PATCH v2.1 09/17] mm/damon/sysfs: implement preps directory SJ Park
2026-07-27 14:38 ` SJ Park [this message]
2026-07-27 14:38 ` [RFC PATCH v2.1 11/17] mm/damon/sysfs: create directories for nr_preps writes SJ Park
2026-07-27 14:38 ` [RFC PATCH v2.1 12/17] mm/damon/sysfs: implement prep_action file SJ Park
2026-07-27 14:38 ` [RFC PATCH v2.1 13/17] mm/damon/sysfs: pass preps to DAMON core SJ Park
2026-07-27 14:38 ` [RFC PATCH v2.1 14/17] selftests/damon/sysfs.sh: test probe prep sysfs files SJ Park
2026-07-27 14:38 ` [RFC PATCH v2.1 15/17] Docs/mm/damon/design: document probe preps SJ Park
2026-07-27 14:38 ` [RFC PATCH v2.1 16/17] Docs/admin-guide/mm/damon/usage: document probe preps sysfs files SJ Park
2026-07-27 14:38 ` [RFC PATCH v2.1 17/17] Docs/ABI/damon: document probe prep " SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260727143829.86236-11-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox