Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Yosry Ahmed <yosry@kernel.org>
Cc: Hao Jia <jiahao.kernel@gmail.com>,
	tj@kernel.org, hannes@cmpxchg.org, shakeel.butt@linux.dev,
	mhocko@kernel.org, mkoutny@suse.com, nphamcs@gmail.com,
	chengming.zhou@linux.dev, muchun.song@linux.dev,
	roman.gushchin@linux.dev, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	Hao Jia <jiahao1@lixiang.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH v3 1/2] mm/zswap: Fix global shrinker when memory cgroup is disabled
Date: Thu, 30 Jul 2026 10:59:52 -0700	[thread overview]
Message-ID: <20260730105952.7878a648c43c32b5e649d96d@linux-foundation.org> (raw)
In-Reply-To: <CAO9r8zMPxdn=MOFD9mbrzed+C9HhOB5DpHG4QS0OJzqV_gLvsQ@mail.gmail.com>

On Thu, 30 Jul 2026 09:52:38 -0700 Yosry Ahmed <yosry@kernel.org> wrote:

> > > >
> > > > How does this affect users?  What behavior do they observe when it
> > > > occurs?
> > >
> > > I think the first paragraph sums it up pretty well, especially the
> > > last sentence "hotter pages with higher fault latency".
> >
> > How do users observe that?
> >
> > See, what I'm looking for here is an explanation for why we're
> > proposing a backport.  How are our users harmed by the current code and
> > how does this change benefit them?
> 
> It's a potential performance regression when using zswap with memcg
> disabled. Sorry I just realized you were looking for a high level
> description not detailed symptoms :)

Are we able to guess how significant this is?  It should have
significant impact to justify a backport.

Sorry to push - I'm forever trying to train people to describe the
userspace-visible effects so we can make these backporting decisions!

And to justify those decisions to -stable maintainers

And so that someone who is experiencing a slowdown in some private
kernel branch can look at the changelog and decide whether this might
fix it for them.



  reply	other threads:[~2026-07-30 18:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29  8:42 [PATCH v3 0/2] mm/zswap: Fixes and improves the zswap shrink Hao Jia
2026-07-29  8:42 ` [PATCH v3 1/2] mm/zswap: Fix global shrinker when memory cgroup is disabled Hao Jia
2026-07-29 22:58   ` Andrew Morton
2026-07-30  0:30     ` Yosry Ahmed
2026-07-30  1:17       ` Andrew Morton
2026-07-30 16:52         ` Yosry Ahmed
2026-07-30 17:59           ` Andrew Morton [this message]
2026-07-30 18:02             ` Yosry Ahmed
2026-07-30  6:31       ` Hao Jia
2026-07-30 17:48         ` Yosry Ahmed
2026-07-30 19:01           ` Johannes Weiner
2026-07-29  8:42 ` [PATCH v3 2/2] mm/zswap: Support batch writeback in shrink_memcg() Hao Jia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260730105952.7878a648c43c32b5e649d96d@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=chengming.zhou@linux.dev \
    --cc=hannes@cmpxchg.org \
    --cc=jiahao.kernel@gmail.com \
    --cc=jiahao1@lixiang.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mkoutny@suse.com \
    --cc=muchun.song@linux.dev \
    --cc=nphamcs@gmail.com \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeel.butt@linux.dev \
    --cc=stable@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=yosry@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox