Re: [RFC PATCH] mm/damon: introduce damos_sort_type for re-ordering regions list

[Liew Rui Yan <aethernet65535@gmail.com>]

Hi SJ,

First of all, I apologize for the noise, and I will drop this patch.
Secondly, thank you for pointing this out, it made me realize that I was
fixing a non-existent problem.

On Tue,  4 Aug 2026 06:58:33 -0700 SJ Park <sj@kernel.org> wrote:

> The recommended way is setting the min_age naive, and auto-tune it using DAMOS
> quota or aim-oriented quota auto-tuning.  Have you considered using that?

> This sounds like very similar to DAMOS quota's regions prioritizing mechanism.
> Have you considered using DAMOS quota?  If so, could you please add why
> proposing this new mechanism, with some comparisons?

Yes, I have. And you are right; the existing mechanism is better. I
wrote this patch because I misunderstood quota.min_score and did not
even check the implementation of damos_adjust_quota().

Whether when implementing dama [1] or this damos_sort_type, I failed to
realize that min_age might not be such an important parameter on a
long-running system, and there is really no need to introduce
auto-tuning or a new mechanism for it.

> I to be honest feel this is too much for "just guess" based patch.  I'd like to
> get clear reasoning of the change and/or test results before reviewing the
> code.  So I'm holding the code review until the high level discussion is done.

Moving forward, I will ensure I am not "reinventing the wheel" or
"fixing non-existent problem".

Thank you again for pointing this out. In the future contributions, I
will try my best to avoid spending time fixing problems that do not
actually exist.

[1] https://lore.kernel.org/damon/20260628085155.20828-1-aethernet65535@gmail.com

Best regards,
Rui Yan