From: Andrew Morton <akpm@linux-foundation.org>
To: Ye Liu <ye.liu@linux.dev>
Cc: Vlastimil Babka <vbabka@kernel.org>, Ye Liu <liuye@kylinos.cn>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Brendan Jackman <brendan.jackman@linux.dev>,
Johannes Weiner <hannes@cmpxchg.org>, Zi Yan <ziy@nvidia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: debug_page_alloc: fix type mismatch for debug_guardpage_minorder
Date: Wed, 5 Aug 2026 09:49:09 -0700 [thread overview]
Message-ID: <20260805094909.9e84940cc1f83502a41e2d96@linux-foundation.org> (raw)
In-Reply-To: <20260805093108.2352900-1-ye.liu@linux.dev>
On Wed, 5 Aug 2026 17:31:07 +0800 Ye Liu <ye.liu@linux.dev> wrote:
>
> The _debug_guardpage_minorder variable is declared as unsigned int,
> but the debug_guardpage_minorder_setup() function uses unsigned long
> and kstrtoul() to parse the value.
>
> Use kstrtouint() with unsigned int local variable to match the actual
> type of _debug_guardpage_minorder. Also fix the format specifier
> from %lu to %u accordingly.
Fair enough, thanks.
AI review seems to have found a little pre-existing bug in there,
https://sashiko.dev/#/patchset/20260805093108.2352900-1-ye.liu@linux.dev
prev parent reply other threads:[~2026-08-05 16:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 9:31 [PATCH] mm: debug_page_alloc: fix type mismatch for debug_guardpage_minorder Ye Liu
2026-08-05 16:49 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260805094909.9e84940cc1f83502a41e2d96@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=brendan.jackman@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuye@kylinos.cn \
--cc=mhocko@suse.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=ye.liu@linux.dev \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox