From: Andrew Morton <akpm@linux-foundation.org>
To: Ridong <ridong.chen@linux.dev>
Cc: "Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Hocko" <mhocko@kernel.org>,
"Roman Gushchin" <roman.gushchin@linux.dev>,
"Shakeel Butt" <shakeel.butt@linux.dev>,
"Muchun Song" <muchun.song@linux.dev>,
"Tejun Heo" <tj@kernel.org>, "Michal Koutný" <mkoutny@suse.com>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, cui.tao@linux.dev,
"Ridong Chen" <chenridong@xiaomi.com>
Subject: Re: [PATCH v2 0/2] mm, memcg: fix memory.peak reset clobbering other fds' watermark
Date: Fri, 7 Aug 2026 13:22:41 -0700 [thread overview]
Message-ID: <20260807132241.147c758d2904e00daf28ba4e@linux-foundation.org> (raw)
In-Reply-To: <20260807090000.1532495-1-ridong.chen@linux.dev>
On Fri, 7 Aug 2026 16:59:58 +0800 Ridong <ridong.chen@linux.dev> wrote:
> Two fixes for the per-fd memory.peak / memory.swap.peak handlers added in
> c6f53ed8f213. Each open fd reads back max(its own value, the shared
> local_watermark), and both bugs live in that scheme.
Thanks.
We're missing the preferred description of the worst-case
userspace-visible effects of the bug. It appears they're quite minor
so I'll assume this series is a post-7.2 thing.
Sashiko might have found a similar race on the writer side:
https://sashiko.dev/#/patchset/20260807090000.1532495-1-ridong.chen@linux.dev
prev parent reply other threads:[~2026-08-07 20:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260807090000.1532495-1-ridong.chen@linux.dev>
2026-08-07 8:59 ` [PATCH v2 1/2] memcg: acquire peaks_lock when reading memory.peak Ridong
2026-08-07 20:22 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260807132241.147c758d2904e00daf28ba4e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chenridong@xiaomi.com \
--cc=cui.tao@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=ridong.chen@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox