From: Andrew Morton <akpm@linux-foundation.org>
To: Guopeng Zhang <guopeng.zhang@linux.dev>
Cc: shakeel.butt@linux.dev, hannes@cmpxchg.org, mhocko@kernel.org,
roman.gushchin@linux.dev, muchun.song@linux.dev,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Guopeng Zhang <zhangguopeng@kylinos.cn>
Subject: Re: [PATCH] mm: memcg-v1: fix memory.memsw.failcnt accounting
Date: Mon, 10 Aug 2026 11:47:49 -0700 [thread overview]
Message-ID: <20260810114749.368140ad5be4fa10085bbee0@linux-foundation.org> (raw)
In-Reply-To: <20260810074247.52747-1-guopeng.zhang@linux.dev>
On Mon, 10 Aug 2026 15:42:47 +0800 Guopeng Zhang <guopeng.zhang@linux.dev> wrote:
> Commit 0e2759afcaf9 ("page_counter: track failcnt only for legacy
> cgroups") made failcnt accounting conditional on track_failcnt. It
> enabled the flag for memcg->memory, but not for memcg->memsw.
>
> Consequently, memory.memsw.failcnt remains zero when the memory+swap
> limit is hit. Enable failcnt accounting for the v1 memsw counter.
>
> Reproducer:
>
> CG=/sys/fs/cgroup/memory/memsw-test
> LIMIT=33554432
> mkdir "$CG"
> echo "$LIMIT" > "$CG/memory.limit_in_bytes"
> echo "$LIMIT" > "$CG/memory.memsw.limit_in_bytes"
>
> Start a child process in the cgroup and make it allocate and touch 96 MiB
> of memory, causing a memcg OOM.
>
> cat "$CG/memory.memsw.failcnt"
>
> Without the patch, memory.memsw.failcnt is 0. With the patch,
> memory.memsw.failcnt is greater than 0.
Thanks. Nice changelog.
> Fixes: 0e2759afcaf9 ("page_counter: track failcnt only for legacy cgroups")
I'll add cc:stable to this.
AI review thinks that memcg->tcpmem.track_failcnt should receive the
same treatment:
https://sashiko.dev/#/patchset/20260810074247.52747-1-guopeng.zhang@linux.dev
next prev parent reply other threads:[~2026-08-10 18:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 7:42 [PATCH] mm: memcg-v1: fix memory.memsw.failcnt accounting Guopeng Zhang
2026-08-10 13:04 ` Michal Hocko
2026-08-10 18:47 ` Andrew Morton [this message]
2026-08-10 19:09 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810114749.368140ad5be4fa10085bbee0@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=guopeng.zhang@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=zhangguopeng@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox