From: Andrew Morton <akpm@linux-foundation.org>
To: Stanislav Kinsburskii <skinsburskii@gmail.com>
Cc: kernel test robot <lkp@intel.com>,
David Hildenbrand <david@kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
mm-commits@vger.kernel.org
Subject: Re: [akpm-mm:mm-new] BUILD SUCCESS WITH UNVERIFIED WARNING e0ffd277b09a7c9f1a436e5f75be37ac490bc59f
Date: Tue, 11 Aug 2026 17:27:13 -0700 [thread overview]
Message-ID: <20260811172713.d9f98913055bf8dc8331cda1@linux-foundation.org> (raw)
In-Reply-To: <anu1N-DOnQwxO1kF@skinsburskii>
On Tue, 11 Aug 2026 16:50:15 -0700 Stanislav Kinsburskii <skinsburskii@gmail.com> wrote:
> > Caused by
> >
> > 121170831228 ("mm/hmm: add hmm_range_fault_unlocked_timeout() for mmap lock-drop support")
> >
> >
> > Stanislaw, you've previously said that this is a can't-happen, but boy
> > I'm getting tired of seeing this warning report. Would the below change
> > hurt anything? I can't immediately think of a cost-free way of doing
> > this.
> >
>
> I think this change doesn't do any harm.
> Perhaps it worth a WARN_ON_ONCE to expose a wrong fault handler
> behavior?
Like this?
if (ret & (VM_FAULT_COMPLETED | VM_FAULT_RETRY)) {
if (hmm_vma_walk->locked) /* needed by sparse */
*hmm_vma_walk->locked = false;
else
WARN_ON_ONCE(1); /* broken fault handler */
return HMM_FAULT_UNLOCKED;
}
next prev parent reply other threads:[~2026-08-12 0:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 2:44 [akpm-mm:mm-new] BUILD SUCCESS WITH UNVERIFIED WARNING e0ffd277b09a7c9f1a436e5f75be37ac490bc59f kernel test robot
2026-08-10 20:23 ` Andrew Morton
2026-08-11 23:50 ` Stanislav Kinsburskii
2026-08-12 0:27 ` Andrew Morton [this message]
2026-08-16 13:34 ` Stanislav Kinsburskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260811172713.d9f98913055bf8dc8331cda1@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mm-commits@vger.kernel.org \
--cc=skinsburskii@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox