From: Enze Li <lienze@kylinos.cn>
To: sj@kernel.org, akpm@linux-foundation.org
Cc: damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, enze.li@gmx.com,
Enze Li <lienze@kylinos.cn>
Subject: [PATCH] mm/damon/stat: avoid iterating targets in damon_stat_sort_regions()
Date: Fri, 14 Aug 2026 22:54:09 +0800 [thread overview]
Message-ID: <20260814145409.553724-1-lienze@kylinos.cn> (raw)
damon/stat module creates only one target in damon_stat_build_ctx(), and
the comment in damon_stat_sort_regions() already says so. But the code
still iterates adaptive_targets with damon_for_each_target(), which is
needlessly verbose and adds an extra indentation level.
Just use list_first_entry() to grab the single target, with a
list_empty() check to be safe.
Signed-off-by: Enze Li <lienze@kylinos.cn>
---
mm/damon/stat.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/mm/damon/stat.c b/mm/damon/stat.c
index b05b68f73e10..c8b1e909bbac 100644
--- a/mm/damon/stat.c
+++ b/mm/damon/stat.c
@@ -91,16 +91,15 @@ static int damon_stat_sort_regions(struct damon_ctx *c,
unsigned int nr_regions = 0;
unsigned long total_sz = 0;
- damon_for_each_target(t, c) {
- /* there is only one target */
- region_pointers = kmalloc_objs(*region_pointers,
- damon_nr_regions(t));
- if (!region_pointers)
- return -ENOMEM;
- damon_for_each_region(r, t) {
- region_pointers[nr_regions++] = r;
- total_sz += r->ar.end - r->ar.start;
- }
+ if (list_empty(&c->adaptive_targets))
+ return -EINVAL;
+ t = list_first_entry(&c->adaptive_targets, struct damon_target, list);
+ region_pointers = kmalloc_objs(*region_pointers, damon_nr_regions(t));
+ if (!region_pointers)
+ return -ENOMEM;
+ damon_for_each_region(r, t) {
+ region_pointers[nr_regions++] = r;
+ total_sz += r->ar.end - r->ar.start;
}
sort(region_pointers, nr_regions, sizeof(*region_pointers),
damon_stat_cmp_regions, NULL);
base-commit: 6c2cdf00fe5205942b5f29e16905603a1717b931
--
2.43.0
next reply other threads:[~2026-08-14 14:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 14:54 Enze Li [this message]
2026-08-15 0:47 ` [PATCH] mm/damon/stat: avoid iterating targets in damon_stat_sort_regions() SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260814145409.553724-1-lienze@kylinos.cn \
--to=lienze@kylinos.cn \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=enze.li@gmx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox