Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Muchun Song <songmuchun@bytedance.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Oscar Salvador <osalvador@suse.de>,
	David Hildenbrand <david@kernel.org>
Cc: Mike Rapoport <rppt@kernel.org>,
	Vlastimil Babka <vbabka@kernel.org>,
	Lorenzo Stoakes <ljs@kernel.org>, Michal Hocko <mhocko@suse.com>,
	David Laight <david.laight.linux@gmail.com>,
	"Liam R . Howlett" <liam@infradead.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Qi Zheng <qi.zheng@linux.dev>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Muchun Song <songmuchun@bytedance.com>,
	Muchun Song <muchun.song@linux.dev>
Subject: [PATCH v5 04/17] mm/sparse-vmemmap: initialize shared tail vmemmap pages on allocation
Date: Tue, 25 Aug 2026 16:45:55 +0800	[thread overview]
Message-ID: <20260825084608.47437-5-songmuchun@bytedance.com> (raw)
In-Reply-To: <20260825084608.47437-1-songmuchun@bytedance.com>

The shared tail vmemmap page allocated in vmemmap_get_tail() used to be
left uninitialized, because memmap_init_range() would later overwrite
it.  That forced users such as HugeTLB to defer the initialization to
their own setup paths.

Now that memmap_init_range() skips shared tail vmemmap pages, initialize
them immediately in vmemmap_get_tail() with init_compound_tail()
instead.

This moves the initialization to the point where the shared tail page is
allocated and avoids relying on deferred handling in individual users.
The remaining deferred initialization in HugeTLB will be removed once it
switches to the section-based vmemmap optimization mechanism.

Signed-off-by: Muchun Song <songmuchun@bytedance.com>
---
 mm/sparse-vmemmap.c | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c
index aa6a4a2fae98..107215cf8488 100644
--- a/mm/sparse-vmemmap.c
+++ b/mm/sparse-vmemmap.c
@@ -338,19 +338,11 @@ static __meminit struct page *vmemmap_get_tail(unsigned int order, struct zone *
 	tail = zone->vmemmap_tails[idx];
 	if (tail)
 		return tail;
-
-	/*
-	 * Only allocate the page, but do not initialize it.
-	 *
-	 * Any initialization done here will be overwritten by memmap_init().
-	 *
-	 * hugetlb_bootmem_struct_page_init() will take care of initialization
-	 * after memmap_init().
-	 */
-
 	p = vmemmap_alloc_block_zero(PAGE_SIZE, node);
 	if (!p)
 		return NULL;
+	for (int i = 0; i < PAGE_SIZE / sizeof(struct page); i++)
+		init_compound_tail(p + i, NULL, order, zone);
 
 	tail = virt_to_page(p);
 	zone->vmemmap_tails[idx] = tail;
-- 
2.54.0



  parent reply	other threads:[~2026-08-25  8:49 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25  8:45 [PATCH v5 00/17] mm: Introduce section-based vmemmap optimization for HugeTLB Muchun Song
2026-08-25  8:45 ` [PATCH v5 01/17] mm/sparse: relax struct mem_section size constraints Muchun Song
2026-08-25  8:45 ` [PATCH v5 02/17] mm/sparse-vmemmap: rename HVO order macros Muchun Song
2026-08-25 10:05   ` Qi Zheng
2026-08-25  8:45 ` [PATCH v5 03/17] mm/mm_init: skip initializing shared vmemmap tail pages Muchun Song
2026-08-25  9:30   ` Mike Rapoport
2026-08-25 10:15   ` Qi Zheng
2026-08-25  8:45 ` Muchun Song [this message]
2026-08-25  9:30   ` [PATCH v5 04/17] mm/sparse-vmemmap: initialize shared tail vmemmap pages on allocation Mike Rapoport
2026-08-25 10:40   ` Qi Zheng
2026-08-25  8:45 ` [PATCH v5 05/17] mm/sparse-vmemmap: support section-based vmemmap accounting Muchun Song
2026-08-25 10:47   ` Qi Zheng
2026-08-25  8:45 ` [PATCH v5 06/17] mm/mm_init: factor out pfn_to_zone() Muchun Song
2026-08-25 10:51   ` Qi Zheng
2026-08-25  8:45 ` [PATCH v5 07/17] mm/sparse-vmemmap: move helpers ahead of future callers Muchun Song
2026-08-25 10:54   ` Qi Zheng
2026-08-25  8:45 ` [PATCH v5 08/17] mm/sparse-vmemmap: support section-based vmemmap optimization Muchun Song
2026-08-25  9:30   ` Mike Rapoport
2026-08-25 12:38   ` Qi Zheng
2026-08-25  8:46 ` [PATCH v5 09/17] mm/sparse: initialize memory sections earlier Muchun Song
2026-08-25 12:49   ` Qi Zheng
2026-08-25  8:46 ` [PATCH v5 10/17] mm/hugetlb: switch HugeTLB to section-based vmemmap optimization Muchun Song
2026-08-25 13:12   ` Qi Zheng
2026-08-26  2:38     ` Muchun Song
2026-08-26  3:24       ` Qi Zheng
2026-08-25  8:46 ` [PATCH v5 11/17] mm/sparse-vmemmap: remove SPARSEMEM_VMEMMAP_PREINIT support Muchun Song
2026-08-25 13:16   ` Qi Zheng
2026-08-25  8:46 ` [PATCH v5 12/17] mm/sparse: inline usemap allocation into sparse_init_nid() Muchun Song
2026-08-25  8:46 ` [PATCH v5 13/17] mm/sparse: remove section_map_size() Muchun Song
2026-08-25  8:46 ` [PATCH v5 14/17] mm/hugetlb: remove HUGE_BOOTMEM_HVO Muchun Song
2026-08-25 13:28   ` Qi Zheng
2026-08-25  8:46 ` [PATCH v5 15/17] mm/hugetlb: remove HUGE_BOOTMEM_CMA Muchun Song
2026-08-25 13:42   ` Qi Zheng
2026-08-25  8:46 ` [PATCH v5 16/17] mm/hugetlb: localize struct huge_bootmem_page Muchun Song
2026-08-25 13:38   ` Qi Zheng
2026-08-25  8:46 ` [PATCH v5 17/17] mm/hugetlb: localize HUGE_BOOTMEM_ZONES_VALID Muchun Song
2026-08-25 13:40   ` Qi Zheng
2026-08-28  4:20 ` [PATCH v5 00/17] mm: Introduce section-based vmemmap optimization for HugeTLB Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260825084608.47437-5-songmuchun@bytedance.com \
    --to=songmuchun@bytedance.com \
    --cc=akpm@linux-foundation.org \
    --cc=david.laight.linux@gmail.com \
    --cc=david@kernel.org \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=muchun.song@linux.dev \
    --cc=osalvador@suse.de \
    --cc=qi.zheng@linux.dev \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox