From: SJ Park <sj@kernel.org>
Cc: SJ Park <sj@kernel.org>,
stable@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
Ravi Jonnalagadda <ravis.opensrc@gmail.com>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [RFC PATCH v1.3 3/4] mm/damon/core: copy nid for eligible_mem_bp damos quota goal commit
Date: Fri, 28 Aug 2026 11:36:47 -0700 [thread overview]
Message-ID: <20260828183649.71192-4-sj@kernel.org> (raw)
In-Reply-To: <20260828183649.71192-1-sj@kernel.org>
damos_commit_quota_goal_union() is not updating the ->nid union field
when the goal metric is DAMOS_QUITA_NODE_ELIGIBLE_MEM_BP. Hence, if a
DAMOS quota goal of the type is online committed in a way that it will
reuse other quota goal's memory space, the new goal will work with a
garbage nid value. As a result, the DAMOS scheme can show unexpected
aggressiveness. Do the update.
The user impact is not catastrophic. No leak or crash happens. Doing
the quota goal online commit that can reproduce the issue is expected to
be not common. This issue was not found by real users but the AI
review. That said, the issue can reliably be reproduced.
This issue was discovered [1] by Sashiko.
[1] https://lore.kkernel.org/20260827045035.94611-1-sj@kernel.org
Fixes: 9138e27a3bc3 ("mm/damon: add node_eligible_mem_bp goal metric")
Cc: <stable@vger.kernel.org> # 7.2.x
Signed-off-by: SJ Park <sj@kernel.org>
---
mm/damon/core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/mm/damon/core.c b/mm/damon/core.c
index 39605e64dabf2..b3f8bea774c2d 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -1136,6 +1136,9 @@ static void damos_commit_quota_goal_union(
dst->nid = src->nid;
dst->memcg_id = src->memcg_id;
break;
+ case DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP:
+ dst->nid = src->nid;
+ break;
default:
break;
}
--
2.47.3
next prev parent reply other threads:[~2026-08-28 18:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 18:36 [RFC PATCH v1.3 0/4] mm/damon: fix misc bugs in kunit, quota goals and sysfs refresh_ms SJ Park
2026-08-28 18:36 ` [RFC PATCH v1.3 1/4] mm/damon/tests/core-kunit: test committing psi goal to psi goal SJ Park
2026-08-28 18:36 ` [RFC PATCH v1.3 2/4] mm/damon/core: handle uninitialized damos_quota_goal->last_psi_total SJ Park
2026-08-28 18:36 ` SJ Park [this message]
2026-08-28 18:36 ` [RFC PATCH v1.3 4/4] mm/damon/sysfs: set next refresh jiffies per sysfs context SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260828183649.71192-4-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ravis.opensrc@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox