Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>,
	 David Hildenbrand <david@kernel.org>,
	 "Liam R. Howlett" <liam@infradead.org>,
	Vlastimil Babka <vbabka@kernel.org>,
	 Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	 Michal Hocko <mhocko@suse.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, ljs@kernel.org
Subject: [PATCH] mm/vmpressure: remove window size TODO
Date: Mon, 31 Aug 2026 14:42:11 +0100	[thread overview]
Message-ID: <20260831-remove-vmpressure-todo-v1-1-498515e59cdf@kernel.org> (raw)

There has been a steady stream of patches that have been submitted by
newcomers to core mm 'fixing' this TODO, with all but the original having
very likely been generated by LLMs.

It appears that TODOs to LLMs are like red rags to a bull.

In addition, TODOs in code often bitrot and are distracting - those who
understand the code know what could be improved in future.

Therefore remove the TODO.

The work required to actually fix this TODO requires somebody who both has
understanding of the code and significant real-world data to back their
changes.

Such a person doesn't require a TODO prompt to implement this change, so
nothing of value is being lost here.

Link: https://lore.kernel.org/all/20260831130316.448-1-tahasezer.is@gmail.com/
Link: https://lore.kernel.org/linux-mm/20260724054305.516126-1-cui.tao@linux.dev/
Link: https://lore.kernel.org/linux-mm/20260715143646.15828-1-gaikwad.dcg@gmail.com/
Link: https://lore.kernel.org/all/20260227221555.29969-1-mcq@disroot.org/
Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
---
 mm/vmpressure.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/mm/vmpressure.c b/mm/vmpressure.c
index 9629240d77ad..3de99fef3928 100644
--- a/mm/vmpressure.c
+++ b/mm/vmpressure.c
@@ -30,9 +30,6 @@
  *
  * As the vmscan reclaimer logic works with chunks which are multiple of
  * SWAP_CLUSTER_MAX, it makes sense to use it for the window size as well.
- *
- * TODO: Make the window size depend on machine size, as we do for vmstat
- * thresholds. Currently we set it to 512 pages (2MB for 4KB pages).
  */
 const unsigned long vmpressure_win = SWAP_CLUSTER_MAX * 16;
 

---
base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
change-id: 20260831-remove-vmpressure-todo-2d764f42059a

Cheers,
-- 
Lorenzo Stoakes (ARM) <ljs@kernel.org>



             reply	other threads:[~2026-08-31 13:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31 13:42 Lorenzo Stoakes (ARM) [this message]
2026-08-31 17:16 ` [PATCH] mm/vmpressure: remove window size TODO Andrew Morton
2026-08-31 17:33   ` Lorenzo Stoakes (ARM)
2026-09-01 14:14 ` Vlastimil Babka (SUSE)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260831-remove-vmpressure-todo-v1-1-498515e59cdf@kernel.org \
    --to=ljs@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox