From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37EE8C61DD3 for ; Mon, 31 Aug 2026 04:21:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F32696B0088; Mon, 31 Aug 2026 00:21:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE2986B008A; Mon, 31 Aug 2026 00:21:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DADB06B008C; Mon, 31 Aug 2026 00:21:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 998F76B0088 for ; Mon, 31 Aug 2026 00:21:24 -0400 (EDT) Received: from smtpin02.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6F0171603F4 for ; Mon, 31 Aug 2026 04:21:22 +0000 (UTC) X-FDA: 85160265204.02.1415E1E Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf05.hostedemail.com (Postfix) with ESMTP id 86AC0100003 for ; Mon, 31 Aug 2026 04:21:20 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=arm.com header.s=foss header.b=YKnzM9BU; spf=pass (imf05.hostedemail.com: domain of sarthak.sharma@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=sarthak.sharma@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1788150081; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=e1bR1fTNRLn4LczucVBl7NUBZ27rknlyfSVMO7uADXE=; b=nujsvrhOKcHiUc4CisUb5pxOSgldUXob0xh1RYy4LYSKu7MMdpTj353XjWxqar8DzT/5ZV XWNIMZUQNxqRRVPjlssRd70034oJUmmZDEYZ7wEsOWOnwOqEYSoKA/OvZJTeDMn4noqzJ8 TtTMd4PUkMxgARbDz37IlRxn486KaYE= ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1788150081; b=y507SaxNeTYksw5JqL0AB7smv7f7vrUK2pYupe8o+c3NeeC+c3SrGAkNh1JpR8kx0HTzAG s0Dp6xVXay0/LY1WPLNNLTula/EGSdJrq5UCN/9BXfXfF9UFQa9VYNLTdo1uwXJSsH3DVf jIz47/+ufObcVaTww/oBHxL6QfcRvYc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=arm.com header.s=foss header.b=YKnzM9BU; spf=pass (imf05.hostedemail.com: domain of sarthak.sharma@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=sarthak.sharma@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 99B7214BF; Sun, 30 Aug 2026 21:21:15 -0700 (PDT) Received: from a081061.blr.arm.com (a081061.arm.com [10.164.19.84]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B62983F8C6; Sun, 30 Aug 2026 21:21:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1788150079; bh=n7qnW/vv3h18XKnYg+MsL4aCV+MeJB4dCNZjbHcjixY=; h=From:To:Cc:Subject:Date:From; b=YKnzM9BUa7CDGvY3ugQPf3qhYeFTChpE0aTXVuEtJHkhrucugqTPogqI3RjbXbcUD QLQa0GDqRaxiSUpPrSsPToxJPevSIqhFRt3kI/QmjzeFpDCx2xVQQSZ8DPYvCTjWfT ddUzoixD0hDxo5JmVBxJbfd8KIdSnJc+/kNtFl6c= From: Sarthak Sharma To: Andrew Morton , David Hildenbrand Cc: Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , Shuah Khan , Jonathan Corbet , Jason Gunthorpe , John Hubbard , Peter Xu , Leon Romanovsky , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Mark Brown , Anshuman Khandual , Muhammad Usama Anjum , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Sarthak Sharma Subject: [PATCH v8 0/6] selftests/mm: separate GUP microbenchmarking from functional testing Date: Mon, 31 Aug 2026 09:50:55 +0530 Message-ID: <20260831042101.18085-1-sarthak.sharma@arm.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 86AC0100003 X-Stat-Signature: fo3uuh15584dg5h5z478j57pi5euazyq X-HE-Tag: 1788150080-144045 X-HE-Meta: U2FsdGVkX19Kp4zkp4t7U3vv/0WceADnuM4aGDW+KZQ9ybkRYPjZB4os2BLv/sOfY0+1Zv19iCpXQ2jAPKJWPHrWRABmFqoG7ePtxoH+BcfI5obT1D3QWanbqdUr7nw3rA+Zxd8P2ZTRVQ+dfV1TyaNGmCkTk4JrK/v3yzU2ZuaVHJR/HOzFoTS19n63Vb+qfl69/lSChJz/DX+avjQGT7iZibY5JWpiaVVvWVhJx4GPmsDStSyJPb4FBKBBbsFsCzKekQRrRTACMtbRwGDxuKlosjSYb81IhCEhuljdPZ5Zq1L0ZwGwnMwVbVQ+Mf0J6Gi4k69cBEz0/Vjwc6+uzeHfR73rUDlOZD8n9ovcAmdFqSmCwDhZr0+BeNFVpzAKaB8nmabvTK17sTRebHb6DuQxkhya9pH661SfmrYZ7aVaB6LYYt+XkosakSQ0wULz1kjVSEdLKJ7Z7oxSf0vWqyUNk0vvC3gJs0P/25dWLGXE3u7SDnnEiQ+R8LdV3YGwpjwqKnWj2w5KrSWRKHAmZLy+F9Z6xcG1i+b37UUEJ4AlYp3iXgq3nZQJIqYcGP/qaNIk0nbclpBZSFB1dmNBEKlB1JQN3vB1ZAuHVj9wKv3oUoqPHYzfl1ppFpaDp/dtBV8aByja8BrHUu6sonWCz6RlddnF9opEEOmE97NSJBOw62S+p1xkXU1LSzALvHHdthftQNIcuWcuqcIR/jpjqhLrH1Kq2B8JWC2aDHUS5+Ogyjr58kH6BbP/aWBbcOad4vtZwAgxvlc6cai92h+tL0HOYD1W7EFzKxOpbK4Vd4AJ6ActsNE7PK2i//yK8uu57FBFLbzK4XL+QBqHzthUrUKM5eBtJ9BjprJC7w28P7NTjh10h5jMK6EJhZZ7c0TceBaH68ZA2jliNqJm1u1p+zyKC2BebnhNeaySs/HzXwpbAXVzBtbUpTmLZkrWLQB6IPH4utpTv20ittAQ7/S PzqgdKNA 6GqX4gGwl26qCqIFJZM5d3n27kZN9yDOP7W2jpHhElEMHzhRWb56opxwGLWre3gsNnBxrsy1VFy96YLQ/2RhzN712Rjv/La9AJUjzF2duPzz3vsAcQv44uSgcrgV/WallOYwfzNWItFh/V6KlBomrmHIxmRrJngC1UJFudVVuEUJyj4yRFIkPRwLY8f2znEeLJB5v763FcY38hqMFmH8Za7x5pSqvbcpo7ua4CcQUO5tGOMhJOVTdce8qrHQqHaTpx6S71ODw/XJLss0= Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: gup_test.c currently serves two separate purposes: benchmarking (GUP_FAST_BENCHMARK, PIN_FAST_BENCHMARK and PIN_LONGTERM_BENCHMARK) and functional testing (GUP_BASIC_TEST, PIN_BASIC_TEST and DUMP_USER_PAGES_TEST). Keeping both in one program makes the functional tests harder to run and report individually, while run_vmtests.sh has to invoke the program repeatedly with different options. Separate these roles into tools/mm/gup_bench for benchmarking and tools/testing/selftests/mm/gup for functional testing. Move the shared file and hugepage helpers to tools/lib/mm/ so both programs can use them without duplicating the implementation. Patch 1 makes read_file(), write_file(), read_num(), write_num() and write_num_ignore_einval() return errors to their callers instead of exiting. It also makes read_num() reject negative and malformed values and updates the existing callers to handle failures. Patch 2 moves these file helpers from vm_util.c to tools/lib/mm/. It keeps them available to the mm selftests through vm_util.h and adjusts the selftests build accordingly. Patch 3 moves hugepage_settings.[ch] from selftests/mm to tools/lib/mm/. It also removes its kselftest dependency while preserving TAP-compatible diagnostics for selftest users. Patch 4 moves the existing gup_test implementation from selftests/mm to tools/mm as gup_bench. This keeps the code movement separate from the subsequent changes and makes it easier to review. Patch 5 removes the functional test modes and kselftest dependency from gup_bench. When run without arguments, it performs one GUP_FAST benchmark using the existing defaults instead of running the whole matrix. Other benchmark configurations can be selected through command-line options. Patch 6 adds a new harness-based GUP selftest. It covers THP, non-THP and HugeTLB mappings across private/shared and read/write variants. For each variant, it tests get_user_pages(), get_user_pages_fast(), pin_user_pages(), pin_user_pages_fast() and long-term pinning modes using four batch sizes. The HugeTLB variants share a one-time setup of 128 default-sized huge pages. Changes in v8: - Add a comment to clarify read_num() input validation - Remove duplicate exit code in gup_bench - Drop DUMP_USER_PAGES_TEST coverage from gup - Update Documentation and Kconfig Changes in v7: - Rebase onto mm-unstable - Address feedback from Mike and Sashiko - Make read_file() return 0 on success and tighten read_num() parsing - Move write_num_ignore_einval() with the shared file helpers - Keep the existing gup_bench argument parsing and avoid unrelated checks - Set up 128 HugeTLB pages once for all HugeTLB selftest variants Changes in v6: - Rebase onto v7.2-rc5 - Address feedback from David, Mark, John, Dev and Sashiko - Keep the shared file helpers silent and let callers report errors - Move the existing gup_test into tools/mm before changing its behaviour - Report ioctl failures from gup_bench worker threads - Remove the default benchmark matrix and run one default benchmark instead - Add the new harness-based functional selftest in a separate final patch - Drop the unrelated thp_swap_allocator_test .gitignore change Changes in v5: - Rebase onto v7.2-rc3 - Address feedback from Mike, John, Dev and Sashiko - Make file helper diagnostics TAP-compatible - Validate read_num() input and propagate errors while restoring shared memory limits - Preserve build bisectability for the x86 protection_keys test - Preserve HugeTLB diagnostics using TAP-compatible printf() output - Validate the remaining numeric arguments accepted by gup_bench Changes in v4: - Address review feedback from Mike and Sashiko - Add a preparatory patch so shared file helpers return errors instead of exiting - Reduce include churn by keeping shared helpers exposed through vm_util.h - Preserve HugeTLB diagnostics and restore HugeTLB state more carefully - Fix selftests/mm build details after moving helpers to tools/lib/mm - Tighten gup_bench argument handling and gup_test setup/sparse-dump coverage Changes in v3: - Address v2 feedback from Sashiko - Add shared file_utils helpers under tools/lib/mm - Move hugepage_settings out of selftests and into tools/lib/mm - Convert gup_bench to use the shared tools/lib/mm helpers - Guard against invalid thread counts in gup_bench - Handle thread-array allocation failure cleanly in gup_bench - Restore HugeTLB settings on setup failure in gup_test - Add sparse DUMP_USER_PAGES_TEST coverage for pages 0, 19 and 0x1000 Changes in v2: - Address v1 feedback from Sashiko - Add fast and long-term GUP/PUP coverage - Sweep nr_pages_per_call over 1, 512, 123 and all pages - Call madvise(MADV_NOHUGEPAGE) in non-THP variants - Use 256 MB for HugeTLB fixtures - Restore HugeTLB settings from fixture teardown - Report nr_pages_per_call for each iteration - Update the pin_user_pages unit-testing documentation Previous versions: v7: lore.kernel.org/all/20260813181230.483746-1-sarthak.sharma@arm.com/ v6: lore.kernel.org/all/20260730140825.238130-1-sarthak.sharma@arm.com/ v5: lore.kernel.org/all/20260716123226.197736-1-sarthak.sharma@arm.com/ v4: lore.kernel.org/all/20260527142432.230127-1-sarthak.sharma@arm.com/ v3: lore.kernel.org/all/20260521111801.173019-1-sarthak.sharma@arm.com/ v2: lore.kernel.org/all/20260519120506.184512-1-sarthak.sharma@arm.com/ v1: lore.kernel.org/all/20260515084840.174652-1-sarthak.sharma@arm.com/ --- Sarthak Sharma (6): selftests/mm: make file helpers return errors tools/lib/mm: add shared file helpers tools/lib/mm: move hugepage_settings out of selftests tools/mm: move gup_test from selftests/mm to tools/mm tools/mm: make gup_bench a benchmark only tool selftests/mm: add a GUP selftest Documentation/core-api/pin_user_pages.rst | 9 - MAINTAINERS | 4 +- mm/Kconfig | 21 +- tools/lib/mm/file_utils.c | 106 +++++++ tools/lib/mm/file_utils.h | 13 + .../selftests => lib}/mm/hugepage_settings.c | 109 +++++-- .../selftests => lib}/mm/hugepage_settings.h | 0 tools/mm/.gitignore | 1 + tools/mm/Makefile | 11 +- .../mm/gup_test.c => mm/gup_bench.c} | 191 ++++++------ tools/testing/selftests/mm/Makefile | 15 +- tools/testing/selftests/mm/compaction_test.c | 2 +- tools/testing/selftests/mm/cow.c | 1 - .../selftests/mm/folio_split_race_test.c | 1 - tools/testing/selftests/mm/guard-regions.c | 1 - tools/testing/selftests/mm/gup.c | 277 ++++++++++++++++++ tools/testing/selftests/mm/gup_longterm.c | 1 - tools/testing/selftests/mm/hmm-tests.c | 6 +- tools/testing/selftests/mm/hugetlb-madvise.c | 1 - tools/testing/selftests/mm/hugetlb-mmap.c | 1 - tools/testing/selftests/mm/hugetlb-mremap.c | 1 - tools/testing/selftests/mm/hugetlb-shm.c | 1 - .../selftests/mm/hugetlb-soft-offline.c | 2 +- tools/testing/selftests/mm/hugetlb_dio.c | 1 - .../selftests/mm/hugetlb_fault_after_madv.c | 1 - .../selftests/mm/hugetlb_madv_vs_map.c | 1 - tools/testing/selftests/mm/khugepaged.c | 15 +- tools/testing/selftests/mm/ksm_tests.c | 1 - tools/testing/selftests/mm/migration.c | 2 +- tools/testing/selftests/mm/pagemap_ioctl.c | 1 - .../testing/selftests/mm/prctl_thp_disable.c | 1 - tools/testing/selftests/mm/protection_keys.c | 2 +- tools/testing/selftests/mm/run_vmtests.sh | 37 +-- tools/testing/selftests/mm/soft-dirty.c | 1 - .../selftests/mm/split_huge_page_test.c | 6 +- tools/testing/selftests/mm/thuge-gen.c | 1 - tools/testing/selftests/mm/transhuge-stress.c | 1 - tools/testing/selftests/mm/uffd-common.h | 1 - tools/testing/selftests/mm/uffd-wp-mremap.c | 2 +- .../selftests/mm/va_high_addr_switch.c | 1 - tools/testing/selftests/mm/vm_util.c | 121 ++------ tools/testing/selftests/mm/vm_util.h | 8 +- 42 files changed, 656 insertions(+), 323 deletions(-) create mode 100644 tools/lib/mm/file_utils.c create mode 100644 tools/lib/mm/file_utils.h rename tools/{testing/selftests => lib}/mm/hugepage_settings.c (87%) rename tools/{testing/selftests => lib}/mm/hugepage_settings.h (100%) rename tools/{testing/selftests/mm/gup_test.c => mm/gup_bench.c} (50%) create mode 100644 tools/testing/selftests/mm/gup.c -- 2.53.0