From: Andrew Morton <akpm@linux-foundation.org>
To: Hao Ge <hao.ge@linux.dev>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Petr Pavlu <petr.pavlu@suse.com>,
Daniel Gomez <da.gomez@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>,
Aaron Tomlin <atomlin@atomlin.com>,
Suren Baghdasaryan <surenb@google.com>,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v7 0/4] alloc_tag and module codetag section fixes
Date: Wed, 2 Sep 2026 15:05:01 -0700 [thread overview]
Message-ID: <20260902150501.d589742ba33d0beeb0cdb21f@linux-foundation.org> (raw)
In-Reply-To: <20260902081802.146145-1-hao.ge@linux.dev>
On Wed, 2 Sep 2026 16:17:58 +0800 Hao Ge <hao.ge@linux.dev> wrote:
> I ran into an overflow problem in the module tag area. With profiling
> toggled off, the overflow check in reserve_module_tags() did not
> run, a module could load with more tags than the page flags can
> address, and re-enabling profiling then silently corrupted
> /proc/allocinfo. On overflow the fix shuts profiling down, releases
> the reservation and returns -EAGAIN, and the codetag section lands
> as regular module data in the same load, so the module loads without
> profiling.
>
> Review of the earlier series by Sashiko turned up two more problems.
Thanks. Sashiko had a lot more to say, as I assume you've seen:
https://sashiko.dev/#/patchset/20260902081802.146145-1-hao.ge@linux.dev
Also, "Based-on-a-patch-by:" isn't a recognized thing, although it's
been used ~30 times in the past.
I'm ambivalent about ad-hoc invention of new tags, although it happens
a lot. Perhaps it would be better to do
Based on a patch by Petr Pavlu [1].
...
Link: ... [1]
?
next prev parent reply other threads:[~2026-09-02 22:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 8:17 [PATCH v7 0/4] alloc_tag and module codetag section fixes Hao Ge
2026-09-02 8:17 ` [PATCH v7 1/4] alloc_tag: move release_module_tags() above reserve_module_tags() Hao Ge
2026-09-02 8:18 ` [PATCH v7 2/4] module: introduce SH_ENTSIZE_STANDALONE for separately allocated sections Hao Ge
2026-09-04 16:10 ` Petr Pavlu
2026-09-02 8:18 ` [PATCH v7 3/4] module: allocate codetag sections before the regular module layout Hao Ge
2026-09-02 8:18 ` [PATCH v7 4/4] alloc_tag: release the reservation when populate fails Hao Ge
2026-09-02 22:05 ` Andrew Morton [this message]
2026-09-03 6:30 ` [PATCH v7 0/4] alloc_tag and module codetag section fixes Hao Ge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902150501.d589742ba33d0beeb0cdb21f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=atomlin@atomlin.com \
--cc=da.gomez@kernel.org \
--cc=hao.ge@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=samitolvanen@google.com \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox