From: Kunwu Chan <kunwu.chan@gmail.com>
To: SJ Park <sj@kernel.org>
Cc: Kunwu Chan <kunwu.chan@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Kunwu Chan <kunwu.chan@gmail.com>
Subject: Re: [PATCH 03/12] mm/damon/vaddr: remove a debug message
Date: Thu, 3 Sep 2026 10:24:22 +0800 [thread overview]
Message-ID: <20260903022431.74074-1-kunwu.chan@linux.dev> (raw)
In-Reply-To: <20260902054747.99370-4-sj@kernel.org>
On Tue, 1 Sep 2026 22:47:36 -0700 SJ Park <sj@kernel.org> wrote:
> There is a debug message in the DAMON virtual address space operation
> set. It has not really been used in a meaningful way for the last few
> years, though. Remove it.
>
> Signed-off-by: SJ Park <sj@kernel.org>
> ---
> mm/damon/vaddr.c | 16 +++-------------
> 1 file changed, 3 insertions(+), 13 deletions(-)
>
> diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c
> index c8c32b2ae0402..f884d3f78f30a 100644
> --- a/mm/damon/vaddr.c
> +++ b/mm/damon/vaddr.c
> @@ -189,22 +189,12 @@ static int damon_va_three_regions(struct damon_target *t,
> * <BIG UNMAPPED REGION 2>
> * <stack>
> */
> -static void __damon_va_init_regions(struct damon_ctx *ctx,
> - struct damon_target *t)
> +static void __damon_va_init_regions(struct damon_target *t)
> {
> - struct damon_target *ti;
> struct damon_addr_range regions[3];
> - int tidx = 0;
>
> - if (damon_va_three_regions(t, regions)) {
> - damon_for_each_target(ti, ctx) {
Thanks for the cleanup. The debug message was the only user of
ctx here, so the signature cleanup follows naturally.
Reviewed-by: Kunwu Chan <kunwu.chan@gmail.com>
Thanks,
Kunwu
> - if (ti == t)
> - break;
> - tidx++;
> - }
> - pr_debug("Failed to get three regions of %dth target\n", tidx);
> + if (damon_va_three_regions(t, regions))
> return;
> - }
>
> damon_set_regions(t, regions, 3, DAMON_MIN_REGION_SZ);
> }
> @@ -217,7 +207,7 @@ static void damon_va_init(struct damon_ctx *ctx)
> damon_for_each_target(t, ctx) {
> /* the user may set the target regions as they want */
> if (!damon_nr_regions(t))
> - __damon_va_init_regions(ctx, t);
> + __damon_va_init_regions(t);
> }
> }
>
> --
> 2.47.3
>
Sent using hkml (https://github.com/sjp38/hackermail)
next prev parent reply other threads:[~2026-09-03 2:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 5:47 [PATCH 00/12] mm/damon: cleanup code, add test cases, and update guidances in docs SJ Park
2026-09-02 5:47 ` [PATCH 01/12] mm/damon/core: use damon_nr_samples_per_aggr() for max merge threshold SJ Park
2026-09-03 2:00 ` Kunwu Chan
2026-09-02 5:47 ` [PATCH 02/12] mm/damon/core: remove debug messages SJ Park
2026-09-02 6:14 ` SJ Park
2026-09-02 5:47 ` [PATCH 03/12] mm/damon/vaddr: remove a debug message SJ Park
2026-09-03 2:24 ` Kunwu Chan [this message]
2026-09-02 5:47 ` [PATCH 04/12] mm/damon/core: validate number of probes in valid_probe_params() SJ Park
2026-09-02 15:32 ` Kunwu Chan
2026-09-02 5:47 ` [PATCH 05/12] mm/damon/sysfs: remove probes number validation SJ Park
2026-09-02 14:07 ` Kunwu Chan
2026-09-02 14:37 ` SJ Park
2026-09-02 15:33 ` Kunwu Chan
2026-09-02 5:47 ` [PATCH 06/12] mm/damon/tests/core-kunit: extend set_regions() test for error case SJ Park
2026-09-02 5:47 ` [PATCH 07/12] mm/damon/tests/core-kunit: test <=0 size damon_set_regions() inputs SJ Park
2026-09-02 5:47 ` [PATCH 08/12] mm/damon/tests/core-kunit: test overlapping ranges for set_regions() SJ Park
2026-09-03 3:04 ` Kunwu Chan
2026-09-02 5:47 ` [PATCH 09/12] mm/damon/tests/core-kunit: test damon_nr_samples_per_aggr() SJ Park
2026-09-02 15:08 ` Kunwu Chan
2026-09-02 15:19 ` SJ Park
2026-09-02 15:49 ` Kunwu Chan
2026-09-03 0:22 ` SJ Park
2026-09-02 5:47 ` [PATCH 10/12] selftests/damon/sysfs.sh: test hugepage_mem_bp quota goal SJ Park
2026-09-03 3:06 ` Kunwu Chan
2026-09-02 5:47 ` [PATCH 11/12] Docs/mm/damon/maintainer-profile: update AI review for Sashiko replies SJ Park
2026-09-02 5:47 ` [PATCH 12/12] Docs/ABI/damon: recommend subsystem doc instead of admin-guide SJ Park
2026-09-03 3:09 ` Kunwu Chan
2026-09-02 6:16 ` [PATCH 00/12] mm/damon: cleanup code, add test cases, and update guidances in docs SJ Park
2026-09-02 22:42 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903022431.74074-1-kunwu.chan@linux.dev \
--to=kunwu.chan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=kunwu.chan@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox