From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Rapoport <rppt@kernel.org>
Cc: Song Hu <husong@kylinos.cn>,
linux-mm@kvack.org, muchun.song@linux.dev, osalvador@suse.de,
david@kernel.org, ljs@kernel.org, liam@infradead.org,
vbabka@kernel.org, surenb@google.com, mhocko@suse.com,
shuah@kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mina Almasry <almasrymina@google.com>
Subject: Re: [PATCH 2/2] selftests/mm: restore hidden hugetlb reservation scenarios
Date: Fri, 4 Sep 2026 10:48:12 -0700 [thread overview]
Message-ID: <20260904104812.7ee79803a10ab355ad2cdf81@linux-foundation.org> (raw)
In-Reply-To: <apqBn7tWDHQeMrzB@kernel.org>
On Fri, 4 Sep 2026 11:30:23 +0300 Mike Rapoport <rppt@kernel.org> wrote:
> On Tue, Sep 01, 2026 at 05:37:48PM -0700, Andrew Morton wrote:
> > On Tue, 14 Jul 2026 10:16:30 +0800 Song Hu <husong@kylinos.cn> wrote:
> >
> > > A stray 'continue' in the main loop of charge_reserved_hugetlb.sh made
> > > the "more than reservation", "more than cgroup limit", and "multiple
> > > cgroups" scenarios unreachable, so they never ran.
> > >
> > > Remove it so the first two run again.
> >
> > OK.
> >
> > > The third,
> > > run_multiple_cgroup_test(), is separately broken -- a backslash
> > > line-continuation breaks its local declarations and its hugetlb
> > > reservation accounting does not charge as expected -- and has never run
> > > in CI; skip it explicitly with a comment until fixed.
> >
> > That's reasonable. This code was added by Mina six years ago. But
> > he's still around so let's bug him with a cc ;)
>
> And this code breaks our CI e.g:
>
> https://github.com/linux-mm/linux-mm/actions/runs/33040981840/job/98414290236
What do we need to do to view the error output there?
prev parent reply other threads:[~2026-09-04 17:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 2:16 [PATCH 2/2] selftests/mm: restore hidden hugetlb reservation scenarios Song Hu
2026-09-02 0:37 ` Andrew Morton
2026-09-04 8:30 ` Mike Rapoport
2026-09-04 17:48 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904104812.7ee79803a10ab355ad2cdf81@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=david@kernel.org \
--cc=husong@kylinos.cn \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox